[PR #465] [MERGED] Only format with stable rustfmt #938

New issue

Closed

opened 2026-02-27 20:00:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/465
Author: @willstott101
Created: 4/19/2020
Status: ✅ Merged
Merged: 4/20/2020
Merged by: @ashthespy

Base: dev ← Head: stable-fmt

📝 Commits (3)

69e92b3 Always format with stable rustfmt
d1755f8 Recommend always using stable rustfmt
c39b16b Tweak travis ci to allow nightly failures and only run fmt checks on stable

📊 Changes

2 files changed (+19 additions, -5 deletions)

View changed files

📝 .travis.yml (+17 -3)
📝 CONTRIBUTING.md (+2 -2)

📄 Description

This means there are 5 distinct travis jobs - delaying the nightly build as we're only allowed 4 parrallel. But I've also made nightly an allowed_fail and enabled fast_finish which means the over-all time-to-ci-result is at worst the same as before. We'll see formatting failures in under 2 minutes which is nice.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/465 **Author:** [@willstott101](https://github.com/willstott101) **Created:** 4/19/2020 **Status:** ✅ Merged **Merged:** 4/20/2020 **Merged by:** [@ashthespy](https://github.com/ashthespy) **Base:** `dev` ← **Head:** `stable-fmt` --- ### 📝 Commits (3) - [`69e92b3`](https://github.com/librespot-org/librespot/commit/69e92b31f3a196d48a77f842e202ebd9a17f2b4d) Always format with stable rustfmt - [`d1755f8`](https://github.com/librespot-org/librespot/commit/d1755f8a7e0ff1a44ded03d92cde446d7b427643) Recommend always using stable rustfmt - [`c39b16b`](https://github.com/librespot-org/librespot/commit/c39b16b10ce08dac7664e4f742286bb1797231f4) Tweak travis ci to allow nightly failures and only run fmt checks on stable ### 📊 Changes **2 files changed** (+19 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+17 -3) 📝 `CONTRIBUTING.md` (+2 -2) </details> ### 📄 Description This means there are 5 distinct travis jobs - delaying the nightly build as we're only allowed 4 parrallel. But I've also made nightly an allowed_fail and enabled fast_finish which means the over-all time-to-ci-result is at worst the same as before. We'll see formatting failures in under 2 minutes which is nice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:31 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:21 +03:00

[PR #938] [MERGED] Fix --device argument to various backends #1152

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#938

No description provided.

Rows
Columns