starred/librespot

Fork 0

mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00

[PR #938] [MERGED] Fix `--device` argument to various backends #1152

New issue

Closed

opened 2026-02-27 20:01:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/938
Author: @roderickvd
Created: 1/12/2022
Status: ✅ Merged
Merged: 1/14/2022
Merged by: @roderickvd

Base: dev ← Head: fix-pipe-subprocess-device-arg

📝 Commits (2)

dac5e28 Fix --device argument to various backends
e069a0b Reintroduce check for "" device name

📊 Changes

5 files changed (+42 additions, -57 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 playback/src/audio_backend/pipe.rs (+15 -6)
📝 playback/src/audio_backend/rodio.rs (+9 -12)
📝 playback/src/audio_backend/subprocess.rs (+17 -9)
📝 src/main.rs (+0 -30)

📄 Description

Fixes #936.

This removes the The ``--{}`` / ``-{}`` option is not supported by the included audio backend(s), and has no effect. message that was introduced by @JasonLG1979. I couldn't find an easy and maintainable way of implementing this in all backends (like a fn supports_device() -> bool where Self:: Sized method in the Sink trait) and thought that low code complexity trumps here.

Also some small cleanups and the change that pipe now creates a file if it didn't already exist.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/938 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 1/12/2022 **Status:** ✅ Merged **Merged:** 1/14/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix-pipe-subprocess-device-arg` --- ### 📝 Commits (2) - [`dac5e28`](https://github.com/librespot-org/librespot/commit/dac5e286974ff90e201338164f3404ebd8b0485a) Fix `--device` argument to various backends - [`e069a0b`](https://github.com/librespot-org/librespot/commit/e069a0b06163cf13b106a1fe6d9f2120badeb272) Reintroduce check for "" device name ### 📊 Changes **5 files changed** (+42 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `playback/src/audio_backend/pipe.rs` (+15 -6) 📝 `playback/src/audio_backend/rodio.rs` (+9 -12) 📝 `playback/src/audio_backend/subprocess.rs` (+17 -9) 📝 `src/main.rs` (+0 -30) </details> ### 📄 Description Fixes #936. This removes the `The ``--{}`` / ``-{}`` option is not supported by the included audio backend(s), and has no effect.` message that was introduced by @JasonLG1979. I couldn't find an easy and maintainable way of implementing this in all backends (like a `fn supports_device() -> bool where Self:: Sized` method in the `Sink` trait) and thought that low code complexity trumps here. Also some small cleanups and the change that `pipe` now creates a file if it didn't already exist. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:21 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:44 +03:00

[PR #1152] [MERGED] Update rsa #1253

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1152

No description provided.

Rows
Columns

[PR #938] [MERGED] Fix --device argument to various backends #1152

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description

[PR #938] [MERGED] Fix `--device` argument to various backends #1152