[PR #425] [CLOSED] Fix error handling for closed channel. #919

New issue

Closed

opened 2026-02-27 20:00:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/425
Author: @kaymes
Created: 1/22/2020
Status: ❌ Closed

Base: dev ← Head: account-change-crash

📝 Commits (1)

362106d Fix error handling for closed channel.

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 core/src/channel.rs (+2 -1)

📄 Description

I improved the error handling of the channel receiver to avoid crashing if the channel has been closed.

This (hopefully) fixes #417 (crash when changing accounts). Unfortunately I can't test this myself at the moment because I don't have two accounts at hand.

fixes #417

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/425 **Author:** [@kaymes](https://github.com/kaymes) **Created:** 1/22/2020 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `account-change-crash` --- ### 📝 Commits (1) - [`362106d`](https://github.com/librespot-org/librespot/commit/362106df622126f8ee2af3038a7eeb45b424229f) Fix error handling for closed channel. ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `core/src/channel.rs` (+2 -1) </details> ### 📄 Description I improved the error handling of the channel receiver to avoid crashing if the channel has been closed. This (hopefully) fixes #417 (crash when changing accounts). Unfortunately I can't test this myself at the moment because I don't have two accounts at hand. fixes #417 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:27 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:19 +03:00

[PR #919] [MERGED] player: ensure load threads are done when dropping PlayerInternal #1141

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#919

No description provided.

Rows
Columns