[PR #919] [MERGED] player: ensure load threads are done when dropping PlayerInternal #1141

New issue

Closed

opened 2026-02-27 20:01:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/919
Author: @gdesmott
Created: 12/29/2021
Status: ✅ Merged
Merged: 12/29/2021
Merged by: @roderickvd

Base: new-api ← Head: race-fix

📝 Commits (1)

3ce9854 player: ensure load threads are done when dropping PlayerInternal

📊 Changes

3 files changed (+30 additions, -2 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 playback/Cargo.toml (+1 -0)
📝 playback/src/player.rs (+28 -2)

📄 Description

Fix a race where the load operation was trying to use a disposed tokio
context, resulting in panic.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/919 **Author:** [@gdesmott](https://github.com/gdesmott) **Created:** 12/29/2021 **Status:** ✅ Merged **Merged:** 12/29/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `new-api` ← **Head:** `race-fix` --- ### 📝 Commits (1) - [`3ce9854`](https://github.com/librespot-org/librespot/commit/3ce9854df5f16b6229bb3213340c90dbe2ff2963) player: ensure load threads are done when dropping PlayerInternal ### 📊 Changes **3 files changed** (+30 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `playback/Cargo.toml` (+1 -0) 📝 `playback/src/player.rs` (+28 -2) </details> ### 📄 Description Fix a race where the load operation was trying to use a disposed tokio context, resulting in panic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:19 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:43 +03:00

[PR #1141] [MERGED] Update github actions and add Dependabot #1247

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1141

No description provided.

Rows
Columns