[PR #351] [MERGED] Bump up vergen (and switch to rustc-env flags) #886

Closed
opened 2026-02-27 20:00:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/351
Author: @ashthespy
Created: 7/15/2019
Status: Merged
Merged: 9/21/2019
Merged by: @ashthespy

Base: masterHead: vergen


📝 Commits (1)

  • 2bf694a Bump up vergen (and switch to rustc-env flags)

📊 Changes

5 files changed (+53 additions, -48 deletions)

View changed files

📝 Cargo.lock (+1 -12)
📝 Cargo.toml (+0 -4)
📝 core/Cargo.toml (+1 -1)
📝 core/build.rs (+10 -29)
📝 core/src/version.rs (+41 -2)

📄 Description

Since we are doing some general housekeeping anyway!

Not quite sure what vergen was doing as a build dependency for the binary though. Looks to be a straggler from when the librespot-core was split out in https://github.com/librespot-org/librespot/issues/130?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/351 **Author:** [@ashthespy](https://github.com/ashthespy) **Created:** 7/15/2019 **Status:** ✅ Merged **Merged:** 9/21/2019 **Merged by:** [@ashthespy](https://github.com/ashthespy) **Base:** `master` ← **Head:** `vergen` --- ### 📝 Commits (1) - [`2bf694a`](https://github.com/librespot-org/librespot/commit/2bf694a07bb7a44ea55eef1107e76e5644d518e9) Bump up vergen (and switch to rustc-env flags) ### 📊 Changes **5 files changed** (+53 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -12) 📝 `Cargo.toml` (+0 -4) 📝 `core/Cargo.toml` (+1 -1) 📝 `core/build.rs` (+10 -29) 📝 `core/src/version.rs` (+41 -2) </details> ### 📄 Description Since we are doing some general housekeeping anyway! Not quite sure what `vergen` was doing as a build dependency for the binary though. Looks to be a straggler from when the `librespot-core` was split out in https://github.com/librespot-org/librespot/issues/130? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:00:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#886
No description provided.