[PR #886] [MERGED] parse environment variables #1130

Closed
opened 2026-02-27 20:01:17 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/886
Author: @JasonLG1979
Created: 11/23/2021
Status: Merged
Merged: 12/1/2021
Merged by: @roderickvd

Base: devHead: parse_env_var


📝 Commits (5)

  • a239eb2 parse environment variables
  • e2c3808 Merge branch 'librespot-org:dev' into parse_env_var
  • ca783cf log all parsed environment variables and command line arguments
  • 819c4f8 Merge branch 'dev' into parse_env_var
  • 7205db0 Use to_str instead of into_string

📊 Changes

2 files changed (+134 additions, -74 deletions)

View changed files

📝 CHANGELOG.md (+2 -0)
📝 src/main.rs (+132 -74)

📄 Description

  • Make librespot able to parse environment variables for options and flags. To avoid name collisions environment variables must be prepended with LIBRESPOT_ so option/flag foo-bar becomes LIBRESPOT_FOO_BAR.

  • Verbose logging mode (-v, --verbose, LIBRESPOT_VERBOSE=) now logs all parsed environment variables and command line arguments (credentials are redacted).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/886 **Author:** [@JasonLG1979](https://github.com/JasonLG1979) **Created:** 11/23/2021 **Status:** ✅ Merged **Merged:** 12/1/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `parse_env_var` --- ### 📝 Commits (5) - [`a239eb2`](https://github.com/librespot-org/librespot/commit/a239eb21d369417bb401e8d65a6927130bf192e9) parse environment variables - [`e2c3808`](https://github.com/librespot-org/librespot/commit/e2c380809a77ced1ef83f58c676c14270aa108f4) Merge branch 'librespot-org:dev' into parse_env_var - [`ca783cf`](https://github.com/librespot-org/librespot/commit/ca783cf3bfc1ac22232371c82288657bb523dabd) log all parsed environment variables and command line arguments - [`819c4f8`](https://github.com/librespot-org/librespot/commit/819c4f8fa1a0a27786bf344c3e58e333a13c4426) Merge branch 'dev' into parse_env_var - [`7205db0`](https://github.com/librespot-org/librespot/commit/7205db0030baebca5c0dda2b8fe3cb3618ab23fc) Use to_str instead of into_string ### 📊 Changes **2 files changed** (+134 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -0) 📝 `src/main.rs` (+132 -74) </details> ### 📄 Description * Make librespot able to parse environment variables for options and flags. To avoid name collisions environment variables must be prepended with `LIBRESPOT_` so option/flag `foo-bar` becomes `LIBRESPOT_FOO_BAR`. * Verbose logging mode (`-v`, `--verbose`, `LIBRESPOT_VERBOSE=`) now logs all parsed environment variables and command line arguments (credentials are redacted). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:17 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1130
No description provided.