[PR #206] [MERGED] do not panic on connection reset #835

New issue

Closed

opened 2026-02-27 20:00:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/206
Author: @lrbalt
Created: 4/21/2018
Status: ✅ Merged
Merged: 4/25/2018
Merged by: @sashahilton00

Base: master ← Head: master

📝 Commits (2)

2aea0e8 do not panic on connection reset
ab70e6e run rustfmt --all

📊 Changes

7 files changed (+36 additions, -6 deletions)

View changed files

📝 audio/src/decrypt.rs (+1 -1)
📝 audio/src/fetch.rs (+1 -1)
📝 audio/src/lewton_decoder.rs (+1 -1)
📝 connect/src/spirc.rs (+4 -0)
📝 core/src/session.rs (+24 -2)
📝 playback/src/mixer/softmixer.rs (+1 -1)
📝 playback/src/player.rs (+4 -0)

📄 Description

If Spotify cannot communicate with your Librespot device, the connection is reset. This patch handles this case by stopping the Session, Spirc and Player. Librespot then keeps listening for new connections

This should fix #196 and #134

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/206 **Author:** [@lrbalt](https://github.com/lrbalt) **Created:** 4/21/2018 **Status:** ✅ Merged **Merged:** 4/25/2018 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`2aea0e8`](https://github.com/librespot-org/librespot/commit/2aea0e8fe6eda38d3123b33048cd9752ff2d8221) do not panic on connection reset - [`ab70e6e`](https://github.com/librespot-org/librespot/commit/ab70e6ec4008379dc86a6ba7af833b96a917b19b) run rustfmt --all ### 📊 Changes **7 files changed** (+36 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `audio/src/decrypt.rs` (+1 -1) 📝 `audio/src/fetch.rs` (+1 -1) 📝 `audio/src/lewton_decoder.rs` (+1 -1) 📝 `connect/src/spirc.rs` (+4 -0) 📝 `core/src/session.rs` (+24 -2) 📝 `playback/src/mixer/softmixer.rs` (+1 -1) 📝 `playback/src/player.rs` (+4 -0) </details> ### 📄 Description If Spotify cannot communicate with your Librespot device, the connection is reset. This patch handles this case by stopping the Session, Spirc and Player. Librespot then keeps listening for new connections This should fix #196 and #134 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:08 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#835

No description provided.

Rows
Columns