mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #295] possibility to have a passthrough option when using pipe #196
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#196
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @philippe44 on GitHub (Mar 6, 2019).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/295
Is this possible to bypass the Vorbis decoder when using the pipe output so that the untouched Vorbis encoded data is sent onto the pipe
@michaelherger commented on GitHub (Mar 8, 2019):
Now that's a question I'd be very much interested in, too. Obviously :-)
@kingosticks commented on GitHub (Mar 8, 2019):
Out of interest, what's the usecases for this? The one I can think of isn't a great direction for this project.
@michaelherger commented on GitHub (Mar 8, 2019):
It's not what you think. I'm using a modified version of librespot to stream Spotify to the Squeezebox players. The Squeezebox can play ogg directly. Which means that the transcoding is unnecessary overhead - which can be a problem when users are running it on under-powered systems like some NAS. Right now it would by default transcode from OGG to PCM (in librespot), then to FLAC (in Squeezebox territory).
@sashahilton00 commented on GitHub (Mar 11, 2019):
If you want to submit a PR to add it as a runtime flag, be my guest. Spotify is suitably disengaged from the developer community to the extent that if they're not providing that functionality, I don't have a problem with librespot providing it, so long as it's not just dumping it into a file for obvious reasons. I'm sure Spotify will be in touch if they have a problem with it 🙃
@philippe44 commented on GitHub (Mar 12, 2019):
As said by @michaelherger, there was no nefarious intent at all, the only objective was a LMS cpu and bw reduction
I thought that because a pipe mode already exists, then whether the result of that pipe is raw or in any format did not matter.
I did submit a request and not a PR because unfortunately I know nothing about Rust so what I was expecting to be a fairly small change is beyond my reach. But I understand how it’s hard to deal with such request when you have better to do (I have a few projects here as well)
I will try to find support to do that mod and then file a PR later is successful.
@sashahilton00 commented on GitHub (Feb 22, 2021):
This is currently in progress in PR #569, hence closing in favour of that.