mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #1226] librespot crashes if volume is not changed first #562
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#562
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nrwiersma on GitHub (Nov 24, 2023).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/1226
Describe the bug
I am running librespot via raspotify. When I connect using Spotify Connect and play a song, it instantly crashes. If I change the volume first, it does not crash.
To reproduce
Steps to reproduce the behavior:
Log
Host (what you are running
librespoton):@nrwiersma commented on GitHub (Dec 4, 2023):
I have been running through the versions to see where things break. It seems this is the last "working" version before I see the issue:
librespot 0.4.2 70997e9 (Built on 2023-03-16, Build ID: flowgGlc, Profile: release)@roderickvd commented on GitHub (Dec 17, 2023):
There aren't any different 0.4.2 releases of librespot. But maybe there are different releases of raspotify?
Please try a vanilla librespot here (so not packaged with raspotify).
@nrwiersma commented on GitHub (Dec 18, 2023):
Hi. I am aware that vanilla 0.4.2 does not have this issue. Raspotify has its own builds. But the issue remains the same on the dev branch I guess. It seems if I dont change the volume first, I end up here when I first press play:
https://github.com/librespot-org/librespot/blob/dev/playback/src/player.rs#L1509C26-L1509C64
On 0.4.2, I end up in the same place:
https://github.com/librespot-org/librespot/blob/v0.4.2/playback/src/player.rs#L1284
but in this case it is just a warning, so it does not play but also does not exit.