[PR #1084] [MERGED] [dev] core: spclient: parse lyrics #1226

New issue

Closed

opened 2026-02-27 20:01:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1084
Author: @gdesmott
Created: 12/26/2022
Status: ✅ Merged
Merged: 1/4/2023
Merged by: @roderickvd

Base: dev ← Head: lyrics

📝 Commits (2)

f72048e metadata: add lyrics
7f2cb68 fix clippy warnings

📊 Changes

13 files changed (+94 additions, -16 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 Cargo.lock (+2 -0)
📝 connect/src/spirc.rs (+1 -1)
📝 core/src/authentication.rs (+1 -1)
📝 discovery/src/server.rs (+3 -3)
📝 metadata/Cargo.toml (+2 -0)
📝 metadata/src/audio/item.rs (+1 -1)
📝 metadata/src/lib.rs (+2 -0)
➕ metadata/src/lyrics.rs (+77 -0)
📝 playback/src/convert.rs (+1 -7)
📝 playback/src/lib.rs (+1 -1)
📝 playback/src/player.rs (+1 -1)
📝 protocol/build.rs (+1 -1)

📄 Description

Safe users from doing all the parsing themselves.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1084 **Author:** [@gdesmott](https://github.com/gdesmott) **Created:** 12/26/2022 **Status:** ✅ Merged **Merged:** 1/4/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `lyrics` --- ### 📝 Commits (2) - [`f72048e`](https://github.com/librespot-org/librespot/commit/f72048e5e1a6f74c5476eef89a1de37fa7bb118f) metadata: add lyrics - [`7f2cb68`](https://github.com/librespot-org/librespot/commit/7f2cb684c981d8146ceae853eab9a4b1a772f549) fix clippy warnings ### 📊 Changes **13 files changed** (+94 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `Cargo.lock` (+2 -0) 📝 `connect/src/spirc.rs` (+1 -1) 📝 `core/src/authentication.rs` (+1 -1) 📝 `discovery/src/server.rs` (+3 -3) 📝 `metadata/Cargo.toml` (+2 -0) 📝 `metadata/src/audio/item.rs` (+1 -1) 📝 `metadata/src/lib.rs` (+2 -0) ➕ `metadata/src/lyrics.rs` (+77 -0) 📝 `playback/src/convert.rs` (+1 -7) 📝 `playback/src/lib.rs` (+1 -1) 📝 `playback/src/player.rs` (+1 -1) 📝 `protocol/build.rs` (+1 -1) </details> ### 📄 Description Safe users from doing all the parsing themselves. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:38 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1226

No description provided.

Rows
Columns