mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #1188] Panic: source slice length (16) does not match destination slice length (20) #549
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#549
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aykevl on GitHub (Jul 20, 2023).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/1188
Describe the bug
After running for a while, librespot crashes with a huge stacktrace.
To reproduce
I don't know, I think I just left it running for a few hours. Note that my internet connection is weird (see https://github.com/Spotifyd/spotifyd/issues/1211) so that might have something to do with it.
I am hopeful though that the stack trace provides enough clues as to why it crashes.
I'll provide additional information if it happens again.
Log
No full log, but here is the stack trace:
Host (what you are running
librespoton):Additional context
Weirdly, librespot just continued running after what looks like a fatal error to me. From the log it appears that I was trying to start playing some music (which didn't last long due to https://github.com/Spotifyd/spotifyd/issues/1211).
@kingosticks commented on GitHub (Jul 21, 2023):
Please provide version information.
@aykevl commented on GitHub (Jul 22, 2023):
Sorry I forgot, this was the dev branch at the time I made the issue.
@roderickvd commented on GitHub (Jul 22, 2023):
It sometimes happens that the packet isn’t received fully. I thought I had made that piece of the code panic-free but I guess I missed something.
@aykevl commented on GitHub (Jul 24, 2023):
Got a new stack trace:
As the stack trace says, this is librespot
f037e46. I will try to get a stacktrace with debugging information next.@roderickvd commented on GitHub (Jul 25, 2023):
Other than that it would be nice to make it panic-free, I see at the beginning of the log that it fails to bind, that the address is already in use?
@aykevl commented on GitHub (Jul 31, 2023):
I'm not sure why that is. Maybe I was running another librespot instance at the same time, or maybe it's because I have a WireGuard network interface too that librespot doesn't seem to like very much.
(I have now switched to libespot-java because that's the only thing that will work correctly on my network, feel free to close this if there is nothing important to fix).
@thedtvn commented on GitHub (Jul 6, 2024):
same bug with this episode
spotify:episode:78DE1A0rENsT7oS9qhT8o0@thedtvn commented on GitHub (Jul 6, 2024):
ye it works with Java not Rust for some reason
@roderickvd commented on GitHub (Oct 26, 2024):
Does still happen on latest dev? There have been a lot of improvements there since.
@aykevl commented on GitHub (Oct 26, 2024):
I don't know, I've switched to go-librespot which works reliably for me right now.
@roderickvd commented on GitHub (Oct 26, 2024):
Gonna close then, if you don't expect to provide further feedback.
@thedtvn commented on GitHub (Oct 27, 2024):
@roderickvd it still error here is how i fix it ( sory this repo has been hardly modify fron core so i can not push it to here )
github.com/fantasybot-red/librespot@64cb3fb5d0/core/src/file_id.rs (L16)that will make some last bit is 0
@roderickvd commented on GitHub (Oct 27, 2024):
Cool, thanks! I'll remember to push a commit for it manually.
@roderickvd commented on GitHub (Oct 27, 2024):
Just put in your fix @thedtvn with a small change. Since I don't have a Spotify account anymore, could someone test before I put out a 0.6.0 release?