[PR #1012] [CLOSED] implement stop for pipe backend #1188

New issue

Closed

opened 2026-02-27 20:01:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1012
Author: @SolidEva
Created: 6/8/2022
Status: ❌ Closed

Base: dev ← Head: dev

📝 Commits (1)

31589dd implement stop for pipe backend

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 playback/src/audio_backend/pipe.rs (+6 -0)

📄 Description

the pipe device should be closed & reopened between songs when
--disable-gapless is set, implementing stop() achieves this

this is my first rust PR, so apologies if using take() to reset an optional to None is a gross no-no, I'm open to other suggestions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1012 **Author:** [@SolidEva](https://github.com/SolidEva) **Created:** 6/8/2022 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`31589dd`](https://github.com/librespot-org/librespot/commit/31589ddd5e3d30b26f3211a01b36830ce61d7078) implement stop for pipe backend ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `playback/src/audio_backend/pipe.rs` (+6 -0) </details> ### 📄 Description the pipe device should be closed & reopened between songs when --disable-gapless is set, implementing stop() achieves this this is my first rust PR, so apologies if using `take()` to reset an optional to None is a gross no-no, I'm open to other suggestions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:30 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1188

No description provided.

Rows
Columns