[PR #1357] [CLOSED] Rework session keep-alive logic #1357

New issue

Closed

opened 2026-02-27 20:02:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1357
Author: @wisp3rwind
Created: 9/30/2024
Status: ❌ Closed

Base: dev ← Head: pingpong

📝 Commits (4)

a61f707 session: rework keepalive logic to match other clients
064bf3f session: more sophisticated timeout handling
213d54f update Cargo.lock
1ca4ea5 session: refactor keep_alive_task a bit

📊 Changes

3 files changed (+177 additions, -34 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 core/Cargo.toml (+1 -1)
📝 core/src/session.rs (+175 -33)

📄 Description

Tentative fix for #1340. Also add some logging to show the timing (at info level for now, so we're sure that it's available from everyone who tests it).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1357 **Author:** [@wisp3rwind](https://github.com/wisp3rwind) **Created:** 9/30/2024 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `pingpong` --- ### 📝 Commits (4) - [`a61f707`](https://github.com/librespot-org/librespot/commit/a61f707c5c27babe726b065f01e09b4b3c8f722e) session: rework keepalive logic to match other clients - [`064bf3f`](https://github.com/librespot-org/librespot/commit/064bf3fb37749acf5e769a32978ca0bff149eddb) session: more sophisticated timeout handling - [`213d54f`](https://github.com/librespot-org/librespot/commit/213d54f9cd3ed6f42df9125f25a75e20b5a5c1f2) update Cargo.lock - [`1ca4ea5`](https://github.com/librespot-org/librespot/commit/1ca4ea560b134af4e6bf2a8f92ef32b48ec38cec) session: refactor keep_alive_task a bit ### 📊 Changes **3 files changed** (+177 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `core/Cargo.toml` (+1 -1) 📝 `core/src/session.rs` (+175 -33) </details> ### 📄 Description Tentative fix for #1340. Also add some logging to show the timing (at info level for now, so we're sure that it's available from everyone who tests it). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:08 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:02:09 +03:00

[PR #1359] [MERGED] Rework session keep-alive logic v2 #1359

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1357

No description provided.

Rows
Columns