[PR #1318] [MERGED] Update hyper-rustls to 0.27 and adjust CI workflow #1335

New issue

Closed

opened 2026-02-27 20:02:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1318
Author: @yubiuser
Created: 8/29/2024
Status: ✅ Merged
Merged: 9/5/2024
Merged by: @roderickvd

Base: dev ← Head: hyper

📝 Commits (3)

3e85d77 Update hyper-rustls to 0.27.2
8f0c7b2 Install NASM on Windows CI job
78a8c61 Don't use 'cross' for cross-compilation

📊 Changes

5 files changed (+145 additions, -28 deletions)

View changed files

➕ .cargo/config.toml (+3 -0)
📝 .github/workflows/test.yml (+15 -3)
📝 .gitignore (+0 -1)
📝 Cargo.lock (+126 -23)
📝 core/Cargo.toml (+1 -1)

📄 Description

Updates hyper-rustls > 0.27 changed it's backend to aws-lc-rs which requires changes to the build environment.

On windows test this was pretty simple, only change was addition of NASM
The linux cross compilation failed using cross. cross setups a docker based build environment and despite trying hard I could not get it building the armv7 binary (mainly, because bindgen is required to build aws-lc-rs which could not be build successful within the container). Therefore, I decided to replace cross with native cargo cross-compilation support which is not only faster, easier to debug but also got the binary build easily.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1318 **Author:** [@yubiuser](https://github.com/yubiuser) **Created:** 8/29/2024 **Status:** ✅ Merged **Merged:** 9/5/2024 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `hyper` --- ### 📝 Commits (3) - [`3e85d77`](https://github.com/librespot-org/librespot/commit/3e85d77bfb3520e16c35bb7db3912c76e8cc90d7) Update hyper-rustls to 0.27.2 - [`8f0c7b2`](https://github.com/librespot-org/librespot/commit/8f0c7b2b0d91bb6f14d55e8b78ec59a9c8229c07) Install NASM on Windows CI job - [`78a8c61`](https://github.com/librespot-org/librespot/commit/78a8c61f8544f57b46788e0458e36210d26b2bdb) Don't use 'cross' for cross-compilation ### 📊 Changes **5 files changed** (+145 additions, -28 deletions) <details> <summary>View changed files</summary> ➕ `.cargo/config.toml` (+3 -0) 📝 `.github/workflows/test.yml` (+15 -3) 📝 `.gitignore` (+0 -1) 📝 `Cargo.lock` (+126 -23) 📝 `core/Cargo.toml` (+1 -1) </details> ### 📄 Description Updates `hyper-rustls` > 0.27 changed it's backend to `aws-lc-rs` which requires changes to the [build environment](https://github.com/rustls/hyper-rustls/releases/tag/v%2F0.27.0). 1) On windows test this was pretty simple, only change was addition of `NASM` 2) The linux cross compilation failed using `cross`. `cross` setups a docker based build environment and despite trying hard I could not get it building the armv7 binary (mainly, because `bindgen` is required to build `aws-lc-rs` which could not be build successful within the container). Therefore, I decided to replace `cross` with native cargo cross-compilation support which is not only faster, easier to debug but also got the binary build easily. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:03 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1335

No description provided.

Rows
Columns