[PR #1284] [MERGED] Fix/clippy #1318

New issue

Closed

opened 2026-02-27 20:01:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1284
Author: @yubiuser
Created: 5/11/2024
Status: ✅ Merged
Merged: 5/27/2024
Merged by: @roderickvd

Base: dev ← Head: fix/clippy

📝 Commits (6)

5fc8d2d Add rust env variables to devcontainer
0884a0d Fix assigning_clones
ca035c9 Set MSRV in Cargo.toml files to 1.71
99878e0 Fix derivable_impls
27d3c9e Fix clippy::to_string_trait_impl
2a8c4bd Apply reviewer's suggestion

📊 Changes

13 files changed (+28 additions, -30 deletions)

View changed files

📝 .devcontainer/Dockerfile (+3 -0)
📝 Cargo.toml (+1 -1)
📝 audio/Cargo.toml (+1 -1)
📝 connect/Cargo.toml (+1 -1)
📝 core/Cargo.toml (+1 -1)
📝 core/src/config.rs (+2 -7)
📝 core/src/mercury/types.rs (+5 -5)
📝 core/src/session.rs (+7 -7)
📝 core/src/spclient.rs (+3 -3)
📝 discovery/Cargo.toml (+1 -1)
📝 metadata/Cargo.toml (+1 -1)
📝 playback/Cargo.toml (+1 -1)
📝 protocol/Cargo.toml (+1 -1)

📄 Description

Fixes the clippy warning that occur with v1.78. being the new stable. This made the test fail (e.g here).
Addressed the following warnings:

Sidenote: set the environment variables RUST_BACKTRACE and RUSTFLAGS in the devcontainer the same as they are in the github action workflow file.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1284 **Author:** [@yubiuser](https://github.com/yubiuser) **Created:** 5/11/2024 **Status:** ✅ Merged **Merged:** 5/27/2024 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix/clippy` --- ### 📝 Commits (6) - [`5fc8d2d`](https://github.com/librespot-org/librespot/commit/5fc8d2d3e6d15ad958f9024171930a2710b0e37a) Add rust env variables to devcontainer - [`0884a0d`](https://github.com/librespot-org/librespot/commit/0884a0d76a24d2928a829c4971f309f2223b3a7d) Fix assigning_clones - [`ca035c9`](https://github.com/librespot-org/librespot/commit/ca035c9d17a7fc9958abe8a951203ca0054063c3) Set MSRV in Cargo.toml files to 1.71 - [`99878e0`](https://github.com/librespot-org/librespot/commit/99878e0f72184b1f1d0e65f1f32922a30e489da7) Fix derivable_impls - [`27d3c9e`](https://github.com/librespot-org/librespot/commit/27d3c9e92fd060e6d316b46b9a4c8cdad6f809d4) Fix clippy::to_string_trait_impl - [`2a8c4bd`](https://github.com/librespot-org/librespot/commit/2a8c4bdc011d05c26df90387416b6a4bcb49cee2) Apply reviewer's suggestion ### 📊 Changes **13 files changed** (+28 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+3 -0) 📝 `Cargo.toml` (+1 -1) 📝 `audio/Cargo.toml` (+1 -1) 📝 `connect/Cargo.toml` (+1 -1) 📝 `core/Cargo.toml` (+1 -1) 📝 `core/src/config.rs` (+2 -7) 📝 `core/src/mercury/types.rs` (+5 -5) 📝 `core/src/session.rs` (+7 -7) 📝 `core/src/spclient.rs` (+3 -3) 📝 `discovery/Cargo.toml` (+1 -1) 📝 `metadata/Cargo.toml` (+1 -1) 📝 `playback/Cargo.toml` (+1 -1) 📝 `protocol/Cargo.toml` (+1 -1) </details> ### 📄 Description Fixes the clippy warning that occur with v1.78. being the new stable. This made the test fail (e.g [here](https://github.com/librespot-org/librespot/actions/runs/9043092501/job/24850355483)). Addressed the following warnings: - https://rust-lang.github.io/rust-clippy/master/index.html#/to_string_trait_impl - https://rust-lang.github.io/rust-clippy/master/index.html#/assigning_clones - https://rust-lang.github.io/rust-clippy/master/index.html#/incompatible_msrv - https://rust-lang.github.io/rust-clippy/master/index.html#/derivable_impls Sidenote: set the environment variables `RUST_BACKTRACE` and `RUSTFLAGS` in the devcontainer the same as they are in the github action workflow file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:59 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:02:03 +03:00

[PR #1318] [MERGED] Update hyper-rustls to 0.27 and adjust CI workflow #1335

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1318

No description provided.

Rows
Columns