[PR #791] [CLOSED] Add comment setter to PassthroughDecoder #1084

New issue

Closed

opened 2026-02-27 20:01:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/791
Author: @irgendwr
Created: 6/9/2021
Status: ❌ Closed

Base: dev ← Head: PassthroughDecoder-comment

📝 Commits (1)

6789abf Add comment setter to PassthroughDecoder

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 playback/src/decoder/passthrough_decoder.rs (+4 -0)

📄 Description

from https://github.com/librespot-org/librespot/discussions/790:
The new PassthroughDecoder is very useful, but in my case it's still missing a feature that I require: access to the comment field. My use case is to overwrite the comment header in order to add metadata for my audio player.

This PR adds a setter function for the comment field of the PassthroughDecoder.

Feel free to close or change if's not aligned with the requirements.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/791 **Author:** [@irgendwr](https://github.com/irgendwr) **Created:** 6/9/2021 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `PassthroughDecoder-comment` --- ### 📝 Commits (1) - [`6789abf`](https://github.com/librespot-org/librespot/commit/6789abfc101b7e61222d7b49e4f0371c6e355dd0) Add comment setter to PassthroughDecoder ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `playback/src/decoder/passthrough_decoder.rs` (+4 -0) </details> ### 📄 Description *from https://github.com/librespot-org/librespot/discussions/790:* The new `PassthroughDecoder` is very useful, but in my case it's still missing a feature that I require: access to the `comment` field. My use case is to overwrite the comment header in order to add metadata for my audio player. This PR adds a setter function for the `comment` field of the `PassthroughDecoder`. Feel free to close or change if's not aligned with the requirements. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:05 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:38 +03:00

[PR #1084] [MERGED] [dev] core: spclient: parse lyrics #1226

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1084

No description provided.

Rows
Columns