[PR #1070] [MERGED] Fix play track item_type in the examples folder #1219

New issue

Closed

opened 2026-02-27 20:01:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1070
Author: @wholivesinapineappleunderthesea
Created: 11/4/2022
Status: ✅ Merged
Merged: 11/4/2022
Merged by: @roderickvd

Base: dev ← Head: dev

📝 Commits (2)

39b37d3 Update play.rs
b154907 Update play.rs

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 examples/play.rs (+3 -2)

📄 Description

Because of the adding of item_type to SpotifyId and its subsequent switch-case sprawl throughout the codebase, from_base62 is not playable by default. These constructors set the item_type to Unknown.

This was annoying to debug when I ran into this issue so I think the example should be fixed :)

Edit: forgot to add the import for SpotifyItemType which is what the second commit is for.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1070 **Author:** [@wholivesinapineappleunderthesea](https://github.com/wholivesinapineappleunderthesea) **Created:** 11/4/2022 **Status:** ✅ Merged **Merged:** 11/4/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (2) - [`39b37d3`](https://github.com/librespot-org/librespot/commit/39b37d344f4ae40d331a596d2425855a2dd13848) Update play.rs - [`b154907`](https://github.com/librespot-org/librespot/commit/b15490714d600fd12fc7040ba012e9b4fdccd692) Update play.rs ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `examples/play.rs` (+3 -2) </details> ### 📄 Description Because of the adding of item_type to SpotifyId and its subsequent switch-case sprawl throughout the codebase, from_base62 is not playable by default. These constructors set the item_type to Unknown. This was annoying to debug when I ran into this issue so I think the example should be fixed :) Edit: forgot to add the import for SpotifyItemType which is what the second commit is for. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:36 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:51 +03:00

[PR #1219] [CLOSED] Draft: RFC supporting single track repeat #1284

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1219

No description provided.

Rows
Columns