[PR #772] [MERGED] Fix leftovers from merging diverging branches #1070

New issue

Closed

opened 2026-02-27 20:01:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/772
Author: @roderickvd
Created: 5/27/2021
Status: ✅ Merged
Merged: 5/27/2021
Merged by: @roderickvd

Base: dev ← Head: fix-merging-leftovers

📝 Commits (1)

19f0555 Fix leftovers from merging diverging branches

📊 Changes

3 files changed (+5 additions, -91 deletions)

View changed files

📝 playback/src/convert.rs (+4 -4)
➖ playback/src/decoder/libvorbis_decoder.rs (+0 -86)
📝 playback/src/mixer/mappings.rs (+1 -1)

📄 Description

Misplaced comment
Unremoved libvorbis_decoder.rs
Check volume against MAX_VOLUME (what spirc gives) instead of 1.0 (normalised)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/772 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 5/27/2021 **Status:** ✅ Merged **Merged:** 5/27/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix-merging-leftovers` --- ### 📝 Commits (1) - [`19f0555`](https://github.com/librespot-org/librespot/commit/19f0555e7c04dcf686767a8128f1b69bc2f5320d) Fix leftovers from merging diverging branches ### 📊 Changes **3 files changed** (+5 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `playback/src/convert.rs` (+4 -4) ➖ `playback/src/decoder/libvorbis_decoder.rs` (+0 -86) 📝 `playback/src/mixer/mappings.rs` (+1 -1) </details> ### 📄 Description 1. Misplaced comment 2. Unremoved `libvorbis_decoder.rs` 3. Check volume against MAX_VOLUME (what `spirc` gives) instead of `1.0` (normalised) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:03 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:36 +03:00

[PR #1070] [MERGED] Fix play track item_type in the examples folder #1219

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1070

No description provided.

Rows
Columns