[PR #1030] [MERGED] Implement Default trait for vec / hashmap wrappers in metadata #1199

New issue

Closed

opened 2026-02-27 20:01:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1030
Author: @dnlmlr
Created: 7/31/2022
Status: ✅ Merged
Merged: 8/1/2022
Merged by: @roderickvd

Base: dev ← Head: metadata-derive-default-on-listwrappers

📝 Commits (1)

e7348db Default for vec / hashmap wrappers in metadata

📊 Changes

18 files changed (+26 additions, -26 deletions)

View changed files

📝 metadata/src/album.rs (+2 -2)
📝 metadata/src/artist.rs (+3 -3)
📝 metadata/src/audio/file.rs (+1 -1)
📝 metadata/src/availability.rs (+1 -1)
📝 metadata/src/content_rating.rs (+1 -1)
📝 metadata/src/copyright.rs (+1 -1)
📝 metadata/src/episode.rs (+1 -1)
📝 metadata/src/external_id.rs (+1 -1)
📝 metadata/src/image.rs (+2 -2)
📝 metadata/src/playlist/attribute.rs (+3 -3)
📝 metadata/src/playlist/item.rs (+2 -2)
📝 metadata/src/playlist/list.rs (+2 -2)
📝 metadata/src/playlist/operation.rs (+1 -1)
📝 metadata/src/playlist/permission.rs (+1 -1)
📝 metadata/src/restriction.rs (+1 -1)
📝 metadata/src/sale_period.rs (+1 -1)
📝 metadata/src/track.rs (+1 -1)
📝 metadata/src/video.rs (+1 -1)

📄 Description

Derive Default trait for the vec / hashmap wrapper types in librespot-metadata
The wrapped types (Vec / Hashmap) implement Default, so the wrapper types should as well

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1030 **Author:** [@dnlmlr](https://github.com/dnlmlr) **Created:** 7/31/2022 **Status:** ✅ Merged **Merged:** 8/1/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `metadata-derive-default-on-listwrappers` --- ### 📝 Commits (1) - [`e7348db`](https://github.com/librespot-org/librespot/commit/e7348db17c8dead6dad16efb45fa38b6468af91f) Default for vec / hashmap wrappers in metadata ### 📊 Changes **18 files changed** (+26 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `metadata/src/album.rs` (+2 -2) 📝 `metadata/src/artist.rs` (+3 -3) 📝 `metadata/src/audio/file.rs` (+1 -1) 📝 `metadata/src/availability.rs` (+1 -1) 📝 `metadata/src/content_rating.rs` (+1 -1) 📝 `metadata/src/copyright.rs` (+1 -1) 📝 `metadata/src/episode.rs` (+1 -1) 📝 `metadata/src/external_id.rs` (+1 -1) 📝 `metadata/src/image.rs` (+2 -2) 📝 `metadata/src/playlist/attribute.rs` (+3 -3) 📝 `metadata/src/playlist/item.rs` (+2 -2) 📝 `metadata/src/playlist/list.rs` (+2 -2) 📝 `metadata/src/playlist/operation.rs` (+1 -1) 📝 `metadata/src/playlist/permission.rs` (+1 -1) 📝 `metadata/src/restriction.rs` (+1 -1) 📝 `metadata/src/sale_period.rs` (+1 -1) 📝 `metadata/src/track.rs` (+1 -1) 📝 `metadata/src/video.rs` (+1 -1) </details> ### 📄 Description - Derive `Default` trait for the vec / hashmap wrapper types in `librespot-metadata` - The wrapped types (`Vec` / `Hashmap`) implement Default, so the wrapper types should as well --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:32 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1199

No description provided.

Rows
Columns