[PR #710] [MERGED] Tweak dependencies #1030

New issue

Closed

opened 2026-02-27 20:00:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/710
Author: @Johannesd3
Created: 5/1/2021
Status: ✅ Merged
Merged: 5/4/2021
Merged by: @sashahilton00

Base: dev ← Head: dependencies

📝 Commits (7)

ddf41a4 Update lower version bound for some deps
6077a1e Remove unused block-modes dep
1681574 Bump hmac and pbkdf2
9d55f9a Update Cargo.lock
da2cd8c Bump MSRV to 1.48
17b04c4 Remove libc dep
f6a328c Bump getopts

📊 Changes

9 files changed (+155 additions, -191 deletions)

View changed files

📝 .github/workflows/test.yml (+1 -1)
📝 COMPILING.md (+1 -1)
📝 Cargo.lock (+138 -173)
📝 Cargo.toml (+1 -1)
📝 connect/Cargo.toml (+4 -5)
📝 connect/src/discovery.rs (+3 -3)
📝 core/Cargo.toml (+4 -4)
📝 core/src/connection/handshake.rs (+3 -2)
📝 playback/Cargo.toml (+0 -1)

📄 Description

Applied latest updates of crypto dependencies ~~(most notably: the crates aes and aes-ctr were unified)~~ but not aes since it requires rust 1.49.
I realized that the block-modes dependency wasn't used anywhere so I removed it.
~~Bumped zerocopy from 0.3 to 0.5.~~ (Needs rust version 1.51)
Update Cargo.lock
The latest versions of hyper and libmdns require rust 1.46, and sdl requires 1.48, so I bumped the MSRV.
Adjusted some lower bounds of the version range to match the functionality we use. Unfortunately I was not able to make rm Cargo.lock && cargo +nightly build -Z minimal-versions work, but it's a step into the right direction.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/710 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 5/1/2021 **Status:** ✅ Merged **Merged:** 5/4/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `dependencies` --- ### 📝 Commits (7) - [`ddf41a4`](https://github.com/librespot-org/librespot/commit/ddf41a49f26dc4ae9e436ded577b90c3190bbac5) Update lower version bound for some deps - [`6077a1e`](https://github.com/librespot-org/librespot/commit/6077a1ef4e8ed570da91d142f3e7b4955dab119b) Remove unused block-modes dep - [`1681574`](https://github.com/librespot-org/librespot/commit/1681574846d2413df373567047f8d23436269d9d) Bump hmac and pbkdf2 - [`9d55f9a`](https://github.com/librespot-org/librespot/commit/9d55f9aa5f54f831bbfdf03d4b4c7f5f457eee82) Update Cargo.lock - [`da2cd8c`](https://github.com/librespot-org/librespot/commit/da2cd8c9713b556ea095b91fcadaa734dcd16c78) Bump MSRV to 1.48 - [`17b04c4`](https://github.com/librespot-org/librespot/commit/17b04c4b6edbdf48e944ce761df8f4596cb458d5) Remove libc dep - [`f6a328c`](https://github.com/librespot-org/librespot/commit/f6a328c6ecc0320b13ca7dbfd6486233c559903e) Bump getopts ### 📊 Changes **9 files changed** (+155 additions, -191 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+1 -1) 📝 `COMPILING.md` (+1 -1) 📝 `Cargo.lock` (+138 -173) 📝 `Cargo.toml` (+1 -1) 📝 `connect/Cargo.toml` (+4 -5) 📝 `connect/src/discovery.rs` (+3 -3) 📝 `core/Cargo.toml` (+4 -4) 📝 `core/src/connection/handshake.rs` (+3 -2) 📝 `playback/Cargo.toml` (+0 -1) </details> ### 📄 Description * Applied latest updates of crypto dependencies ~(most notably: the crates aes and aes-ctr were unified)~ but not aes since it requires rust 1.49. * I realized that the block-modes dependency wasn't used anywhere so I removed it. * ~Bumped zerocopy from 0.3 to 0.5.~ (Needs rust version 1.51) * Update Cargo.lock * The latest versions of hyper and libmdns require rust 1.46, and sdl requires 1.48, so I bumped the MSRV. * Adjusted some lower bounds of the version range to match the functionality we use. Unfortunately I was not able to make `rm Cargo.lock && cargo +nightly build -Z minimal-versions` work, but it's a step into the right direction. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:53 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:32 +03:00

[PR #1030] [MERGED] Implement Default trait for vec / hashmap wrappers in metadata #1199

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1030

No description provided.

Rows
Columns