starred/librespot-android
1
0
Fork 0
mirror of https://github.com/devgianlu/librespot-android.git synced 2026-04-25 21:35:49 +03:00
Code Issues 5 Projects Releases Packages Wiki Activity

[GH-ISSUE #6] Implement Volume Handling #6

New issue
Open
opened 2026-02-28 14:23:58 +03:00 by kerem · 2 comments
kerem commented 2026-02-28 14:23:58 +03:00
Owner
Copy link

Originally created by @mitschwimmer on GitHub (Apr 25, 2021).
Original GitHub issue: https://github.com/devgianlu/librespot-android/issues/6

Let me begin with a question. The sink API defines a method ".setVolume()". Should this method be implented in such a way that it:

  1. actually controlls the media volume of the device
  2. controls the gain level of the current track. It would default to "1.0" which means flat, unchanged gain
  3. does nothing on Android as most users of this lib would use an "android-idiomatic" way of manipulating volume

I think the third option makes sense. @devgianlu what do you think?

Originally created by @mitschwimmer on GitHub (Apr 25, 2021). Original GitHub issue: https://github.com/devgianlu/librespot-android/issues/6 Let me begin with a question. The sink API defines a method ".setVolume()". Should this method be implented in such a way that it: 1. actually controlls the media volume of the device 2. controls the gain level of the current track. It would default to "1.0" which means flat, unchanged gain 3. does nothing on Android as most users of this lib would use an "android-idiomatic" way of manipulating volume I think the third option makes sense. @devgianlu what do you think?
kerem commented 2026-02-28 14:23:59 +03:00
Author
Owner
Copy link

@devgianlu commented on GitHub (Apr 25, 2021):

On the "desktop" version it controls the line volume directly. Which in Android would be the equivalent of modifying the device volume, but I do not like this idea. I think the best solution is to have double volume control (Linux has master and line volumes):

  • if the volume change event comes from the device it should be a no-op for the library
  • if the volume change event comes from the Spotify API, change the internal volume of the sink.

We should probably have a look at what the original client for Android does.

<!-- gh-comment-id:826341236 --> @devgianlu commented on GitHub (Apr 25, 2021): On the "desktop" version it controls the line volume directly. Which in Android would be the equivalent of modifying the device volume, but I do not like this idea. I think the best solution is to have double volume control (Linux has master and line volumes): - if the volume change event comes from the device it should be a no-op for the library - if the volume change event comes from the Spotify API, change the internal volume of the sink. We should probably have a look at what the original client for Android does.
kerem commented 2026-02-28 14:23:59 +03:00
Author
Owner
Copy link

@iscle commented on GitHub (Feb 7, 2022):

We should probably have a look at what the original client for Android does.

Adding to this old issue, the original Android client does not modify the volume in any way. If you use Spotify Connect from another device, you can't modify the volume of the Android client. This is something I've always thought would be nice to have, and for me, the best way would be modifying the device's volume directly (but only if Spotify is playing).

<!-- gh-comment-id:1031707178 --> @iscle commented on GitHub (Feb 7, 2022): > We should probably have a look at what the original client for Android does. Adding to this old issue, the original Android client does not modify the volume in any way. If you use Spotify Connect from another device, you can't modify the volume of the Android client. This is something I've always thought would be nice to have, and for me, the best way would be modifying the device's volume directly (but only if Spotify is playing).
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
No results found.
Labels
Clear labels   
bug

   
enhancement

   
enhancement

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
enhancement
enhancement
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot-android#6
No description provided.