mirror of
https://github.com/koel/koel.git
synced 2026-04-25 00:36:03 +03:00
[GH-ISSUE #1254] Permissions for /public/img/ directory #715
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#715
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gramakri on GitHub (Nov 10, 2020).
Original GitHub issue: https://github.com/koel/koel/issues/1254
Describe the bug
Koel attempts to write to
/public/img/covers.Environment
Additional context
I am creating a Koel package for Cloudron at https://git.cloudron.io/cloudron/koel-app . On Cloudron, the app is deployed in containers with a readonly filesystem. This means that the application directories are not writable (one has to explicitly mark them as such). It seems Koel writes to
/public/img/coversdirectory. Is this directory meant to be writable by the web application. Same goes for/public/img/artists. Is that directory meant to be writable by the app? Or is it that the entire/publicshould be writable by the app?Thanks!
@gramakri commented on GitHub (Nov 10, 2020):
Relevant forum post - https://forum.cloudron.io/topic/3582/production-error-laravel-log
@BrookeDot commented on GitHub (Dec 30, 2020):
We should likely update the install documentation, to note that
public/img/covers/(and maybepublic/img/*) should be writable. There's also a bit more info on permissions in #667@gramakri commented on GitHub (Dec 30, 2020):
@BrookeDot Should we create empty directories like
public/img/coversetc with .gitignore ? At https://github.com/koel/koel/tree/master/public@phanan commented on GitHub (Dec 30, 2020):
I'm not familiar with Cloudtron, but Koel should be able to write to
public(for manifests and media metadata) andstorage(for logs, library backups, and search indexes in the next major version).@gramakri commented on GitHub (Dec 31, 2020):
@phanan Thanks for your response. I am wondering how update should work since public/ already has sw.js and an index.php which seems to be code and not data. Is the idea that one should replace these two files when updating koel but keep the rest? What if other code files get put in there in the future? Thanks.
@phanan commented on GitHub (Dec 31, 2020):
When updating Koel you should expect any file to be replaceable. Hence, I'm not sure what Cloudtron's readonly mode is.