mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #1236] Firefox media keys #708
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#708
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @joshuamooree on GitHub (Jul 17, 2020).
Original GitHub issue: https://github.com/koel/koel/issues/1236
Firefox now supports media keys (right now has to be enabled in about:config): https://www.ghacks.net/2020/03/23/firefox-will-soon-support-hardware-media-controls/ . As long as media.hardwaremediakeys.enabled and dom.media.mediasession.enabled are set to true, this feature now works in Firefox with no changes to Koel (tested with 78.0.2 on Windows 10). You should mention this in the documentation.
@BrookeDot commented on GitHub (Dec 23, 2020):
I had no idea that Firefox added Media Control support, pretty cool! I looked into this and as of Firefox 81 these are enabled by default:
https://support.mozilla.org/en-US/kb/control-audio-or-video-playback-your-keyboard
The docs currently say:
It sounds like this extended to Firefox now too, but if we are going to update the docs, we should check if we can say on "modern browsers", thus including Safari, Brave, etc. Or if things should be written specifically to Firefox and Chromium-based browsers.
Once that's been determined, a PR can be made on the docs site:
https://github.com/koel/docs/blob/master/src/README.md#using-the-web-interface
@phanan commented on GitHub (Dec 31, 2020):
Isn't it now a norm on macOS? I don't own a Windows anymore (since like forever), so I can't really confirm this.
@BrookeDot commented on GitHub (Jan 1, 2021):
I did some testing on macOS 11 with Safari 13 and didn't work as smoothly as in Chromium or Firefox. I decided to make a PR leaving out Safari for now, it may work but this is at least an improvement.
https://github.com/koel/docs/pull/20/