[PR #406] [MERGED] Allow failure reason to be reported in verbose mode #1236

New issue

Closed

opened 2026-02-26 02:35:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:35:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/406
Author: @X-Ryl669
Created: 8/16/2016
Status: ✅ Merged
Merged: 8/17/2016
Merged by: @phanan

Base: master ← Head: verboseFailure

📝 Commits (1)

48ae655 Allow failure reason to be reported in verbose mode (take 2)

📊 Changes

3 files changed (+24 additions, -3 deletions)

View changed files

📝 app/Console/Commands/SyncMedia.php (+3 -2)
📝 app/Models/File.php (+20 -0)
📝 app/Services/Media.php (+1 -1)

📄 Description

Currently, when the parser chokes on a file, it's counted as a "bad" file, and reported as so.
Yet, we don't know the reason for the failure.
This patch implements this, it uncovers the failure reason from the parser, so the user could act accordingly to fix the issue.

Fix #405

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/406 **Author:** [@X-Ryl669](https://github.com/X-Ryl669) **Created:** 8/16/2016 **Status:** ✅ Merged **Merged:** 8/17/2016 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `verboseFailure` --- ### 📝 Commits (1) - [`48ae655`](https://github.com/koel/koel/commit/48ae655eac9d37b6d703b965f3ec09cf9d2a214e) Allow failure reason to be reported in verbose mode (take 2) ### 📊 Changes **3 files changed** (+24 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/Console/Commands/SyncMedia.php` (+3 -2) 📝 `app/Models/File.php` (+20 -0) 📝 `app/Services/Media.php` (+1 -1) </details> ### 📄 Description Currently, when the parser chokes on a file, it's counted as a "bad" file, and reported as so. Yet, we don't know the reason for the failure. This patch implements this, it uncovers the failure reason from the parser, so the user could act accordingly to fix the issue. Fix #405 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 02:35:55 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1236

No description provided.

Rows
Columns