mirror of
https://github.com/koel/koel.git
synced 2026-04-26 09:15:59 +03:00
[GH-ISSUE #1076] Error when upgrading to 4.0.0 #628
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#628
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @zachron on GitHub (Sep 11, 2019).
Original GitHub issue: https://github.com/koel/koel/issues/1076
Currently upgrading from 3.7.2 -> 4.0.0
php version: PHP 7.3.8
git version: 2.21.0
2 things not sure if they are related or not
(1) followed the instructions for the upgrade. I do not think the submodule is being correctly checked out (when following the upgrade instructions), after the git checkout v4.0.0 the resources/assets directory is empty. if i run 'git submodule init' and 'git submodule update' manually then the resources/assets directory actually gets the submodule data. Doing a pull needs to be done on a branch, not a tag. i would think at least for right now a better upgrade instructions would be:
(2) maybe unrelated but if following the upgrade instructions exactly (or when using the modified upgrade instructions above), when i run 'php artisan koel:init', on the v4.0.0 tag, i get the error: 'In api.php line 48:Call to a member function only() on null'
@SpikeShape commented on GitHub (Sep 11, 2019):
Thats exactly what I am getting when I try to switch from 3.7.2 to 4.0.0.
I followed the instructions and got this error.
I'm running PHP 7.3.9 and git 2.11.0.
@calvarado194 commented on GitHub (Sep 11, 2019):
I ran into the same issues, and they seem to be due to the init command requiring a Laravel update first.
Make sure to run a
composer updateorcomposer installafter checkout and before running the init command.@phanan commented on GitHub (Sep 12, 2019):
@zachron
This is true. I'm so used to working on the
masterbranch, sorry.@calvarado194 That's a good point as well.
I'll update the guide, thanks everyone!