mirror of
https://github.com/koel/koel.git
synced 2026-04-26 17:25:59 +03:00
[GH-ISSUE #2044] [Info] Koel pre-compiled archives do not support 32-bit since v7.6.0 #1076
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1076
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MichaIng on GitHub (Aug 9, 2025).
Original GitHub issue: https://github.com/koel/koel/issues/2044
It is due to
paragonie/sodium_compatsince v2:github.com/paragonie/sodium_compat@75d7cd8Introduced with
github.com/koel/koel@7a8573c, hence since Koel v7.6.0.I do not exactly suggest to change anything about it. But neither docs nor release notes mention it, so I thought it is a good idea to make you aware of it.
Installing dependencies via PHP Composer from source after removing
composer.lockresolves it toparagonie/sodium_compatv1.21.1 on a 32-bit system, so nothing requires v2 in particular.A workaround on a pre-compiled archive it to downgrade
paragonie/sodium_compat, but it fails due to composer scripts runningartisanas well. Hence the check needs to be temporarily disabled. Composer will regenerate it after the downgrade:The step requires PHP
intl, hence this in case needs to be installed/enabled first:=>
Side note:
league/uri-interfacesandleague/uricome with a 64-bit "suggestion" since v7, but no strict dependency. So that one can be ignored for now.@phanan commented on GitHub (Aug 21, 2025):
Thanks for raising the issue. Indeed, the problem does appear to come from said commit, but we can't just downgrade paragonie/sodium_compat because it's required by pusher/pusher-php-server. However, since pusher/pusher-php-server v7.2.3 requires paragonie/sodium_compat ^1.6, installing this specific version should work. Do you think you can check?
@MichaIng commented on GitHub (Aug 21, 2025):
As said, nothing depends on
paragonie/sodium_compatv2.pusher/pusher-php-serveradded optional support for it with v7.2.6, which is indeed the reason why composer then switched toparagonie/sodium_compatv2.1.0, because there was no reason anymore not to do. But also latestpusher/pusher-php-serverstill works withparagonie/sodium_compatv1. The dependency is declared asparagonie/sodium_compat: ^1.6|^2.0, hence all versions from v1.6 on are fine.So Koel could re-add 32-bit support for pre-compiled archives by declaring explicitly
"paragonie/sodium_compat": "<2"or"paragonie/sodium_compat": "^1.0"or"paragonie/sodium_compat": "1.*", whatever meets convention best 🙂.@phanan commented on GitHub (Aug 22, 2025):
Yeah that certainly works too. Will issue a fix!
@MichaIng commented on GitHub (Aug 22, 2025):
Thanks, that makes handling things for our 32-bit users easier 🙂. In case v1.x implies security vulnerabilities/too weak algorithms at some point, maybe not worth to keep it for 32-bit support. But please put a breaking change notice in release notes then 🙂.