[GH-ISSUE #1054] The ‘app.vue’ mount function is executed before the child component 'overlay.vue' created, which results in overlay not receiving the `SHOW_OVERLAY'signal. #623

New issue

Closed

opened 2026-02-26 02:33:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:33:44 +03:00

Owner

Originally created by @liangteng0 on GitHub (Aug 22, 2019).
Original GitHub issue: https://github.com/koel/koel/issues/1054

when enter the app.vue, this.authenticated = false,
app.vue->created() ---> login-form->created() ---> login-form->mounted() --
---> app.vue->mounted() ==> now if have token , this.authenticated = true and init() ==> showOverlay(), but child components 'overlay' may be not created before app.vue.mounted()

so overlay may be not listen SHOW_OVERLAY signal

Originally created by @liangteng0 on GitHub (Aug 22, 2019). Original GitHub issue: https://github.com/koel/koel/issues/1054 when enter the app.vue, this.authenticated = false, app.vue->created() ---> login-form->created() ---> login-form->mounted() -- ---> app.vue->mounted() ==> now if have token , this.authenticated = true and init() ==> showOverlay(), but child components 'overlay' may be not created before app.vue.mounted() so overlay may be not listen SHOW_OVERLAY signal

kerem closed this issue

2026-02-26 02:33:44 +03:00

kerem referenced this issue

2026-02-26 03:30:31 +03:00

[PR #623] [CLOSED] Musixmatch service integration to populate each songs' lyrics field (if available) as they are played. #1300

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#623

No description provided.

Rows
Columns