mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[PR #623] [CLOSED] Musixmatch service integration to populate each songs' lyrics field (if available) as they are played. #1300
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1300
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/623
Author: @alejandro-carstens
Created: 7/17/2017
Status: ❌ Closed
Base:
master← Head:master📝 Commits (10+)
004fbfaAdded Musixmatch Service to populate the songs lyrics as they are played.e130d0cAdded the ->getSongLyrics() method to the SongController show method.2719994Added MUSIXMATCH_API_KEY to .env.example file.9527c8aFixed MusixmatchTest bug.1fc5306Fixed bug in MusixmatchTest taht had to do with location of blob directory.a4d4a32Fixed another bug in MusixmatchTest.4e71e82Fixing test bug.1aa932eAdded MUSIXMATCH_API_KEY param to phpunit.xml to make the tests work in travis CI.854d791Debuging tests.9516564Debuging tests.📊 Changes
18 files changed (+1018 additions, -770 deletions)
View changed files
📝
.env.example(+4 -0)📝
.travis.yml(+1 -0)➕
app/Facades/Musixmatch.php(+13 -0)📝
app/Http/Controllers/API/SongController.php(+2 -0)📝
app/Models/Song.php(+23 -2)➕
app/Providers/MusixmatchServiceProvider.php(+31 -0)➕
app/Services/Musixmatch.php(+113 -0)📝
app/Services/RESTfulService.php(+2 -2)📝
composer.json(+2 -2)📝
composer.lock(+753 -761)📝
config/app.php(+4 -1)📝
config/koel.php(+13 -0)➕
mysql-apt-config_0.8.0-1_all.deb(+0 -0)📝
phpunit.xml(+2 -1)📝
tests/Feature/MediaTest.php(+5 -1)➕
tests/Feature/MusixmatchTest.php(+48 -0)➕
tests/blobs/musixmatch/search.jsonp(+1 -0)➕
tests/blobs/musixmatch/search_failure.jsonp(+1 -0)📄 Description
This pull requests handles the integration of the Musixmatch service in order to populate the lyrics field of each of the songs whose lyrics field is empty (provided that the Musixmatch search API is able to retrieve the lyrics, or if the lyrics are not restricted). To see a working example of the implementation please visit http://koelo-acarste.c9users.io and login with username: demo@koel.com & password: password. I think it is a cool addition. Please let me know what you guys think.
Alejandro
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.