[GH-ISSUE #564] Incorrect Closing Tag in Vue Modal Components Causes Build Error #405

New issue

Closed

opened 2026-02-26 02:33:06 +03:00 by kerem · 1 comment

kerem commented

2026-02-26 02:33:06 +03:00

Owner

Originally created by @ghost on GitHub (Mar 24, 2017).
Original GitHub issue: https://github.com/koel/koel/issues/564

Using version 3.5.5, I am unable to build due to a template issue. I am unsure of whether this is due to the versions of what I have installed or if this is a legitimate issue. Once I have run Composer and installed all of the dependencies, attempting to run npm run build fails to export to public/js/main.js because the following two Vue templates have invalid markup:

/path/to/koel/resources/assets/js/components/modals/add-user-form.vue
/path/to/koel/resources/assets/js/components/modals/edit-user-form.vue

The closing tag for the element <div class="overlay" v-if="newUser"> is </overlay> rather than </div>. Changing this to </div> allows the Vue components to compile as expected.

System info:

Debian 9.0 (x86_64, kernel 4.9.0-2-amd64)
php7.0 7.0.16-3
php7.0-fpm 7.0.16-3
Composer 1.2.2
Node.js 7.7.4
npm 4.1.2

Steps to reproduce:

git clone git@github.com:phanan/koel.git
cd koel && git checkout v3.5.5
npm install && composer install
Update '.env' with user settings
php artisan koel:init
npm run build

Originally created by @ghost on GitHub (Mar 24, 2017). Original GitHub issue: https://github.com/koel/koel/issues/564 Using version 3.5.5, I am unable to build due to a template issue. I am unsure of whether this is due to the versions of what I have installed or if this is a legitimate issue. Once I have run Composer and installed all of the dependencies, attempting to run `npm run build` fails to export to `public/js/main.js` because the following two Vue templates have invalid markup: - `/path/to/koel/resources/assets/js/components/modals/add-user-form.vue` - `/path/to/koel/resources/assets/js/components/modals/edit-user-form.vue` The closing tag for the element `<div class="overlay" v-if="newUser">` is `</overlay>` rather than `</div>`. Changing this to `</div>` allows the Vue components to compile as expected. System info: - Debian 9.0 (x86_64, kernel 4.9.0-2-amd64) - php7.0 7.0.16-3 - php7.0-fpm 7.0.16-3 - Composer 1.2.2 - Node.js 7.7.4 - npm 4.1.2 Steps to reproduce: 1. `git clone git@github.com:phanan/koel.git` 1. `cd koel && git checkout v3.5.5` 1. `npm install && composer install` 1. Update '.env' with user settings 1. `php artisan koel:init` 1. `npm run build`

kerem

2026-02-26 02:33:06 +03:00

closed this issue
added the
[Type] Bug
label

kerem commented

2026-02-26 02:33:07 +03:00

Author

Owner

@phanan commented on GitHub (Mar 25, 2017):

Please use yarn instead of npm.

@phanan commented on GitHub (Mar 25, 2017): Please use `yarn` instead of `npm`.

kerem referenced this issue

2026-02-26 02:35:55 +03:00

[PR #406] [MERGED] Allow failure reason to be reported in verbose mode #1236

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#405

No description provided.

Rows
Columns