mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #344] [RuntimeException] SplFileInfo::getMTime() #250
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#250
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @My1 on GitHub (May 28, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/344
after seeing that my raspi 1b might me too slow for koel I am trying to run this on my laptop for testing and stuff.
This error is quite similar to #285 but as that's closed and wont help me most probably because it aint hebrew I'll open a new issue.
I always get
T: is just my second harddrive where my music resides.
where the file has some unicode stuff.
for me it triggered for exmaple on ☆ and ~ (a fullwidth version of ~)
but the weirdes thing is that I dont get anything in my error file. I can produce errors myself (already tested with a small test file) so it cant be the permissions.
my environment:
node 4.4.5 with npm 2.15.5
composer 1.1.1
koel pulled yesterday, so it's pretty fresh
PHP 7.0.7 x86 Thread safe
Windows 8.1 x64
I checked PHP and mbstring is enabled in the ini so even that cannot be an obstacle.
@phanan commented on GitHub (May 29, 2016):
Maybe relevant: https://github.com/laravel/framework/issues/5221
@My1 commented on GitHub (May 29, 2016):
I dont really know. this says something about the sessions but the issue seems with the unicode (especially because it gets through when I rename it.
@phanan commented on GitHub (Jun 9, 2016):
Don't think this is a Koel issue per se.
@BernardGoldberger commented on GitHub (Aug 10, 2016):
I found a simple way around this issue, modify the
mtimevariable with some gibberish inApp/Models/File.php L70like so,It took me a while to figure this out, but in fact all the other components do not experience any issues with Unicode including
getID3or any of the othersplFileInfovariables.Of course this workaround only works if you don't care to run a force sync every time you do a scan.
@phanan Do you know of any other way to get the modified time so I can give it a test to see if it will work with Unicode?
@phanan commented on GitHub (Aug 11, 2016):
Can you try
$this->mtime = filemtime($this->path);after the$this->path = $this->splFileInfo->getPathname();line?@BernardGoldberger commented on GitHub (Aug 11, 2016):
Same error.
@BernardGoldberger commented on GitHub (Aug 11, 2016):
To think out of the box, what about using some widows library to get this info and tie it to a
if Windows.@JosephSilber commented on GitHub (Aug 11, 2016):
At the very least this should be in a try/catch block:
At least that way you're only force syncing the files that have special Unicode characters in them.
@phanan commented on GitHub (Aug 11, 2016):
@JosephSilber's idea is exactly what I would do.
@BernardGoldberger commented on GitHub (Aug 11, 2016):
While the scan does not fail now, it still skips it as being invalid.
I will try to research more ideas for this.
@phanan commented on GitHub (Aug 11, 2016):
Can you check the
$evariable? I can't reproduce this issue, so this was more or less a blind fix.@BernardGoldberger commented on GitHub (Aug 12, 2016):
Is this what you are looking for?