mirror of
https://github.com/koel/koel.git
synced 2026-04-26 01:06:00 +03:00
[PR #1731] [MERGED] fix: buggy Spotify integration #1859
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1859
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1731
Author: @phanan
Created: 12/27/2023
Status: ✅ Merged
Merged: 12/27/2023
Merged by: @phanan
Base:
master← Head:fix/spotify📝 Commits (1)
d63c6e1fix: buggy Spotify integration📊 Changes
9 files changed (+141 additions, -21 deletions)
View changed files
📝
app/Http/Controllers/API/DataController.php(+2 -0)📝
resources/assets/js/components/album/AlbumInfo.vue(+6 -2)📝
resources/assets/js/components/artist/ArtistInfo.vue(+5 -2)📝
resources/assets/js/components/profile-preferences/LastfmIntegration.vue(+17 -10)➕
resources/assets/js/components/profile-preferences/SpotifyIntegration.spec.ts(+23 -0)➕
resources/assets/js/components/profile-preferences/SpotifyIntegration.vue(+45 -0)➕
resources/assets/js/components/profile-preferences/__snapshots__/SpotifyIntegration.spec.ts.snap(+37 -0)📝
resources/assets/js/components/screens/ProfileScreen.vue(+2 -0)📝
resources/assets/js/composables/useThirdPartyServices.ts(+4 -7)📄 Description
This fixes a bug with Spotify integration that occurs if an installation isn't connected to Last.fm. Closing #1730 and #1653.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.