[PR #1731] [MERGED] fix: buggy Spotify integration #1859

Closed
opened 2026-02-26 03:32:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1731
Author: @phanan
Created: 12/27/2023
Status: Merged
Merged: 12/27/2023
Merged by: @phanan

Base: masterHead: fix/spotify


📝 Commits (1)

  • d63c6e1 fix: buggy Spotify integration

📊 Changes

9 files changed (+141 additions, -21 deletions)

View changed files

📝 app/Http/Controllers/API/DataController.php (+2 -0)
📝 resources/assets/js/components/album/AlbumInfo.vue (+6 -2)
📝 resources/assets/js/components/artist/ArtistInfo.vue (+5 -2)
📝 resources/assets/js/components/profile-preferences/LastfmIntegration.vue (+17 -10)
resources/assets/js/components/profile-preferences/SpotifyIntegration.spec.ts (+23 -0)
resources/assets/js/components/profile-preferences/SpotifyIntegration.vue (+45 -0)
resources/assets/js/components/profile-preferences/__snapshots__/SpotifyIntegration.spec.ts.snap (+37 -0)
📝 resources/assets/js/components/screens/ProfileScreen.vue (+2 -0)
📝 resources/assets/js/composables/useThirdPartyServices.ts (+4 -7)

📄 Description

This fixes a bug with Spotify integration that occurs if an installation isn't connected to Last.fm. Closing #1730 and #1653.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1731 **Author:** [@phanan](https://github.com/phanan) **Created:** 12/27/2023 **Status:** ✅ Merged **Merged:** 12/27/2023 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix/spotify` --- ### 📝 Commits (1) - [`d63c6e1`](https://github.com/koel/koel/commit/d63c6e1cb8608b145bec9010fdd924abc8e04170) fix: buggy Spotify integration ### 📊 Changes **9 files changed** (+141 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/API/DataController.php` (+2 -0) 📝 `resources/assets/js/components/album/AlbumInfo.vue` (+6 -2) 📝 `resources/assets/js/components/artist/ArtistInfo.vue` (+5 -2) 📝 `resources/assets/js/components/profile-preferences/LastfmIntegration.vue` (+17 -10) ➕ `resources/assets/js/components/profile-preferences/SpotifyIntegration.spec.ts` (+23 -0) ➕ `resources/assets/js/components/profile-preferences/SpotifyIntegration.vue` (+45 -0) ➕ `resources/assets/js/components/profile-preferences/__snapshots__/SpotifyIntegration.spec.ts.snap` (+37 -0) 📝 `resources/assets/js/components/screens/ProfileScreen.vue` (+2 -0) 📝 `resources/assets/js/composables/useThirdPartyServices.ts` (+4 -7) </details> ### 📄 Description This fixes a bug with Spotify integration that occurs if an installation isn't connected to Last.fm. Closing #1730 and #1653. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1859
No description provided.