[PR #1492] [CLOSED] fix(metadata): add support for vorbis tags/comments in FileSynchronizer #1730

Closed
opened 2026-02-26 03:32:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1492
Author: @jojoxd
Created: 8/31/2022
Status: Closed

Base: masterHead: feat-fix-flac-vorbis-comments


📝 Commits (3)

  • 60f09cb fix(metadata): add support for vorbis tags/comments in FileSynchronizer
  • 1e30616 fix(metadata/tests): Add test for flac/vorbis comments
  • 76b91e6 Merge branch 'master' into feat-fix-flac-vorbis-comments

📊 Changes

4 files changed (+52 additions, -4 deletions)

View changed files

📝 app/Services/FileSynchronizer.php (+2 -0)
📝 app/Values/SongScanInformation.php (+20 -4)
📝 tests/Integration/Services/FileSynchronizerTest.php (+30 -0)
tests/songs/full-vorbis-comments.flac (+0 -0)

📄 Description

Fixes #1491


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1492 **Author:** [@jojoxd](https://github.com/jojoxd) **Created:** 8/31/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat-fix-flac-vorbis-comments` --- ### 📝 Commits (3) - [`60f09cb`](https://github.com/koel/koel/commit/60f09cb6a4238bc352fb9f1d373a5584b2aeaf20) fix(metadata): add support for vorbis tags/comments in FileSynchronizer - [`1e30616`](https://github.com/koel/koel/commit/1e30616676e8199e506f7585210b4f7db5891583) fix(metadata/tests): Add test for flac/vorbis comments - [`76b91e6`](https://github.com/koel/koel/commit/76b91e6c621dddcc0c7eee25626c3e02370547b9) Merge branch 'master' into feat-fix-flac-vorbis-comments ### 📊 Changes **4 files changed** (+52 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/FileSynchronizer.php` (+2 -0) 📝 `app/Values/SongScanInformation.php` (+20 -4) 📝 `tests/Integration/Services/FileSynchronizerTest.php` (+30 -0) ➕ `tests/songs/full-vorbis-comments.flac` (+0 -0) </details> ### 📄 Description Fixes #1491 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1730
No description provided.