mirror of
https://github.com/koel/koel.git
synced 2026-04-26 01:06:00 +03:00
[PR #1492] [CLOSED] fix(metadata): add support for vorbis tags/comments in FileSynchronizer #1730
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1730
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1492
Author: @jojoxd
Created: 8/31/2022
Status: ❌ Closed
Base:
master← Head:feat-fix-flac-vorbis-comments📝 Commits (3)
60f09cbfix(metadata): add support for vorbis tags/comments in FileSynchronizer1e30616fix(metadata/tests): Add test for flac/vorbis comments76b91e6Merge branch 'master' into feat-fix-flac-vorbis-comments📊 Changes
4 files changed (+52 additions, -4 deletions)
View changed files
📝
app/Services/FileSynchronizer.php(+2 -0)📝
app/Values/SongScanInformation.php(+20 -4)📝
tests/Integration/Services/FileSynchronizerTest.php(+30 -0)➕
tests/songs/full-vorbis-comments.flac(+0 -0)📄 Description
Fixes #1491
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.