[PR #487] [CLOSED] Feature/additional metadata #1267

Closed
opened 2026-02-26 03:30:23 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/487
Author: @alex-phillips
Created: 11/25/2016
Status: Closed

Base: masterHead: feature/additional-metadata


📝 Commits (10+)

  • e8c32f7 added support for disc number of songs, album year, and song genres
  • 5808567 genre is now its own table and songs have a foreign key to its genre
  • dd69b28 added front-end code for genre support
  • a788d91 fixed missing equals
  • 2bcbf7a moved database migrations to proper location
  • 2209f93 fixed invalid genre and genre_id reference
  • 2bb3f42 fixed style issues
  • f95469a more style fixes
  • 3d68af9 fixed SCSS semicolons in .vue files, removed jquery requirement from bad merge of another fork
  • 19dcd79 initial commit of genre store and genre stub

📊 Changes

38 files changed (+1049 additions, -65 deletions)

View changed files

📝 app/Http/Controllers/API/DataController.php (+5 -0)
📝 app/Models/Album.php (+3 -1)
📝 app/Models/File.php (+47 -3)
app/Models/Genre.php (+66 -0)
📝 app/Models/Song.php (+24 -4)
📝 app/Services/Media.php (+9 -1)
📝 database/factories/ModelFactory.php (+10 -0)
database/migrations/2016_04_22_175752_add_year_to_albums_table.php (+31 -0)
database/migrations/2016_04_23_150726_add_disc_to_songs_table.php (+31 -0)
database/migrations/2016_11_18_150838_add_genre_table.php (+39 -0)
database/migrations/2016_11_18_150839_add_genre_id_to_songs_table.php (+33 -0)
resources/assets/js/components/main-wrapper/main-content/genre.vue (+135 -0)
resources/assets/js/components/main-wrapper/main-content/genres.vue (+80 -0)
📝 resources/assets/js/components/main-wrapper/main-content/index.vue (+5 -1)
📝 resources/assets/js/components/main-wrapper/sidebar/index.vue (+7 -1)
📝 resources/assets/js/components/modals/edit-songs-form.vue (+16 -9)
📝 resources/assets/js/components/modals/edit-user-form.vue (+1 -1)
resources/assets/js/components/shared/genre-item.vue (+101 -0)
📝 resources/assets/js/router.js (+12 -1)
📝 resources/assets/js/services/playback.js (+10 -0)

...and 18 more files

📄 Description

Continuation (reopening) of PR https://github.com/phanan/koel/pull/318.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/487 **Author:** [@alex-phillips](https://github.com/alex-phillips) **Created:** 11/25/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/additional-metadata` --- ### 📝 Commits (10+) - [`e8c32f7`](https://github.com/koel/koel/commit/e8c32f748c7e2aa7344430bc51d45bd3fe286ed9) added support for disc number of songs, album year, and song genres - [`5808567`](https://github.com/koel/koel/commit/5808567448fa77de62a36f10bf1be62ecf0f6d4d) genre is now its own table and songs have a foreign key to its genre - [`dd69b28`](https://github.com/koel/koel/commit/dd69b28ff7fa1ef0bb5ee61536c6f319ddd13288) added front-end code for genre support - [`a788d91`](https://github.com/koel/koel/commit/a788d91c14cc0e39245f357680f0aed6605b1ac7) fixed missing equals - [`2bcbf7a`](https://github.com/koel/koel/commit/2bcbf7af175547babc7401af91f29ad59912dea2) moved database migrations to proper location - [`2209f93`](https://github.com/koel/koel/commit/2209f930dc5de4414d43cf5ef9981ed9cfd0999f) fixed invalid genre and genre_id reference - [`2bb3f42`](https://github.com/koel/koel/commit/2bb3f423e7dd6a5967e76363cf3c2dda183e7bcd) fixed style issues - [`f95469a`](https://github.com/koel/koel/commit/f95469ae939da8aaedf33e5fffce4616a163320d) more style fixes - [`3d68af9`](https://github.com/koel/koel/commit/3d68af9635d7113481d00370fa4017675b616307) fixed SCSS semicolons in .vue files, removed jquery requirement from bad merge of another fork - [`19dcd79`](https://github.com/koel/koel/commit/19dcd79ccd74f88e7476a71fcddb6c37982dcc36) initial commit of genre store and genre stub ### 📊 Changes **38 files changed** (+1049 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/API/DataController.php` (+5 -0) 📝 `app/Models/Album.php` (+3 -1) 📝 `app/Models/File.php` (+47 -3) ➕ `app/Models/Genre.php` (+66 -0) 📝 `app/Models/Song.php` (+24 -4) 📝 `app/Services/Media.php` (+9 -1) 📝 `database/factories/ModelFactory.php` (+10 -0) ➕ `database/migrations/2016_04_22_175752_add_year_to_albums_table.php` (+31 -0) ➕ `database/migrations/2016_04_23_150726_add_disc_to_songs_table.php` (+31 -0) ➕ `database/migrations/2016_11_18_150838_add_genre_table.php` (+39 -0) ➕ `database/migrations/2016_11_18_150839_add_genre_id_to_songs_table.php` (+33 -0) ➕ `resources/assets/js/components/main-wrapper/main-content/genre.vue` (+135 -0) ➕ `resources/assets/js/components/main-wrapper/main-content/genres.vue` (+80 -0) 📝 `resources/assets/js/components/main-wrapper/main-content/index.vue` (+5 -1) 📝 `resources/assets/js/components/main-wrapper/sidebar/index.vue` (+7 -1) 📝 `resources/assets/js/components/modals/edit-songs-form.vue` (+16 -9) 📝 `resources/assets/js/components/modals/edit-user-form.vue` (+1 -1) ➕ `resources/assets/js/components/shared/genre-item.vue` (+101 -0) 📝 `resources/assets/js/router.js` (+12 -1) 📝 `resources/assets/js/services/playback.js` (+10 -0) _...and 18 more files_ </details> ### 📄 Description Continuation (reopening) of PR https://github.com/phanan/koel/pull/318. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:30:23 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1267
No description provided.