[GH-ISSUE #729] Distinguish between Video URLs and embedded videos on a page #474

Open
opened 2026-03-02 11:50:09 +03:00 by kerem · 2 comments
Owner

Originally created by @ctschach on GitHub (Dec 12, 2024).
Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/729

Describe the feature you'd like

When you turn on the video download option, I notice that you'll also download embedded videos from a page. This could result in an unexpected amount of data on your hard drive (and that's probably why this is turned off by default) and it's probably not what you want. However, pasting a YouTube Video URL to download a video would be nice.

So it would be great if you could distinguish between video URLs (like YouTube, Vimeo) you paste as a new item and URLs that are referenced on a page. Maybe you can just define a regular expression when to turn video download on and when not.

Something like:

myregex = "(.*youtube.*|.*vimeo\.com.*)
if re.search(myregex, url) is not None:
     downloadVideos = true

Describe the benefits this would bring to existing Hoarder users

You would not end up with unexpected hdd usage for pages that contained videos you are not aware of.

Can the goal of this request already be achieved via other means?

It seams like you can tweak this setting only when launching the container. So "no"

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundamental request

Additional context

No response

Originally created by @ctschach on GitHub (Dec 12, 2024). Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/729 ### Describe the feature you'd like When you turn on the video download option, I notice that you'll also download embedded videos from a page. This could result in an unexpected amount of data on your hard drive (and that's probably why this is turned off by default) and it's probably not what you want. However, pasting a YouTube Video URL to download a video would be nice. So it would be great if you could distinguish between video URLs (like YouTube, Vimeo) you paste as a new item and URLs that are referenced on a page. Maybe you can just define a regular expression when to turn video download on and when not. Something like: ``` myregex = "(.*youtube.*|.*vimeo\.com.*) if re.search(myregex, url) is not None: downloadVideos = true ``` ### Describe the benefits this would bring to existing Hoarder users You would not end up with unexpected hdd usage for pages that contained videos you are not aware of. ### Can the goal of this request already be achieved via other means? It seams like you can tweak this setting only when launching the container. So "no" ### Have you searched for an existing open/closed issue? - [X] I have searched for existing issues and none cover my fundamental request ### Additional context _No response_
Author
Owner

@kamtschatka commented on GitHub (Dec 12, 2024):

A youtube link is also not a video, it is simply a webpage with an embedded video on it.
Adding a list of domains where the video downloader runs might be an option though. Regex is also an option, but I am working on a tool that also allows you to specify a regex and people are simply not capable of understanding how they work (especially since "." means any character).
I think a simple list of comains that get compared might make this feature a lot more user friendly.

<!-- gh-comment-id:2538614911 --> @kamtschatka commented on GitHub (Dec 12, 2024): A youtube link is also not a video, it is simply a webpage with an embedded video on it. Adding a list of domains where the video downloader runs might be an option though. Regex is also an option, but I am working on a tool that also allows you to specify a regex and people are simply not capable of understanding how they work (especially since "." means any character). I think a simple list of comains that get compared might make this feature a lot more user friendly.
Author
Owner

@maelp commented on GitHub (Apr 21, 2025):

For me, video downloads don't work properly, might be nice if the browser extension shows the found videos and let the user selects which ones he would like to download

<!-- gh-comment-id:2817841981 --> @maelp commented on GitHub (Apr 21, 2025): For me, video downloads don't work properly, might be nice if the browser extension shows the found videos and let the user selects which ones he would like to download
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#474
No description provided.