starred/karakeep

Fork 0

mirror of https://github.com/karakeep-app/karakeep.git synced 2026-04-24 23:46:06 +03:00

[PR #1785] [MERGED] feat(mobile): add context aware sharing option in mobile app #1899

New issue

Closed

opened 2026-03-02 11:59:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1785
Author: @xuatz
Created: 7/26/2025
Status: ✅ Merged
Merged: 7/26/2025
Merged by: @MohamedBassem

Base: main ← Head: feat/1188

📝 Commits (2)

796fde2 v1 inside menu
206f4d1 v2 outside menu with share icon

📊 Changes

3 files changed (+103 additions, -7 deletions)

View changed files

📝 apps/mobile/components/bookmarks/BookmarkCard.tsx (+80 -1)
📝 apps/mobile/package.json (+3 -1)
📝 pnpm-lock.yaml (+20 -5)

📄 Description

Summary

add context aware sharing option in mobile app

fixes #1188
Also mentioned in #1054 #1343 #1616 #1779 lol

Details

Originally, @MohamedBassem mentioned that this should be an action in the menu, but maybe it's better UX to have a share icon, although that may eventually clutter up the bookmark bottom row 🤔

For now I attached the screenshots for both versions, and maybe see if anyone have any opinions to chip in on which should we go with?

Notes

For now, only tested on android (physical device).
And only for text, image and url.

Would be nice if someone can help to test the feature on ios (physical device) and also other types of bookmarks ^^

Screenshots

Text to Clipboard

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1785 **Author:** [@xuatz](https://github.com/xuatz) **Created:** 7/26/2025 **Status:** ✅ Merged **Merged:** 7/26/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `feat/1188` --- ### 📝 Commits (2) - [`796fde2`](https://github.com/karakeep-app/karakeep/commit/796fde2313bc67d24cb303ec3145048370dbfdcf) v1 inside menu - [`206f4d1`](https://github.com/karakeep-app/karakeep/commit/206f4d1a37161c0dd4d8f6bdcf969e1eb3a5e66e) v2 outside menu with share icon ### 📊 Changes **3 files changed** (+103 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `apps/mobile/components/bookmarks/BookmarkCard.tsx` (+80 -1) 📝 `apps/mobile/package.json` (+3 -1) 📝 `pnpm-lock.yaml` (+20 -5) </details> ### 📄 Description ## Summary * add context aware sharing option in mobile app fixes #1188 Also mentioned in #1054 #1343 #1616 #1779 lol ## Details Originally, @MohamedBassem mentioned that this should be an action in the menu, but maybe it's better UX to have a share icon, although that may eventually clutter up the bookmark bottom row 🤔 For now I attached the screenshots for both versions, and maybe see if anyone have any opinions to chip in on which should we go with? ## Notes For now, only tested on android (physical device). And only for `text`, `image` and `url`. Would be nice if someone can help to test the feature on ios (physical device) and also other types of bookmarks ^^ ## Screenshots ### Menu Version <img height="500" alt="image" src="https://github.com/user-attachments/assets/93da6a9a-ea2d-4c44-8965-6a748ef833d4" /> ### Share Icon Version <img height="500" alt="image" src="https://github.com/user-attachments/assets/37554976-5d19-4b50-bb49-7ad6852e5a66" /> ### Text to Clipboard <img height="500" alt="image" src="https://github.com/user-attachments/assets/24134450-352e-4935-9a3f-5dcd82b185bb" /> ### Image to native share intent <img height="500" alt="image" src="https://github.com/user-attachments/assets/0b4d7030-9e7f-4361-93aa-ff55dbaabc1d" /> ### Url to native share intent <img height="500" alt="image" src="https://github.com/user-attachments/assets/9a282007-f206-4b23-bd26-2774d8e568ef" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:40 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1899

No description provided.

Rows
Columns