[PR #1477] [CLOSED] ui: harmonize tab bar for link content in preview + enhancements #1834

Closed
opened 2026-03-02 11:59:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1477
Author: @thiswillbeyourgithub
Created: 5/26/2025
Status: Closed

Base: mainHead: ui_tabbar_in_preview


📝 Commits (6)

  • 85185cb refactor: convert LinkContentSection to use tabs for consistent UI
  • 079a065 refactor: align tab bars and adjust content padding in BookmarkPreview
  • e10d959 UI enh: action bar should be higher
  • f2ce580 style: increase action bar button spacing for better touch interaction
  • 5bcea76 feat: increase modal size to reduce wasted space in bookmark preview
  • 9faf86f fix: prevent text selection on tab buttons in BookmarkPreview

📊 Changes

4 files changed (+63 additions, -59 deletions)

View changed files

📝 apps/web/app/dashboard/@modal/(.)preview/[bookmarkId]/page.tsx (+1 -1)
📝 apps/web/components/dashboard/preview/ActionBar.tsx (+1 -1)
📝 apps/web/components/dashboard/preview/BookmarkPreview.tsx (+4 -4)
📝 apps/web/components/dashboard/preview/LinkContentSection.tsx (+57 -53)

📄 Description

This is a continuation of #1425, where now I added a tab bar to choose between "reader view", "archive", etc.

I had to add an ellipsis mechanism in case the UI is super scaled up, otherwise there were overlapping button labels.

Feedback much appreciated!

Screenshot_20250527-003909_1


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1477 **Author:** [@thiswillbeyourgithub](https://github.com/thiswillbeyourgithub) **Created:** 5/26/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `ui_tabbar_in_preview` --- ### 📝 Commits (6) - [`85185cb`](https://github.com/karakeep-app/karakeep/commit/85185cba0277f1709411891113cbc411bb7d3b90) refactor: convert LinkContentSection to use tabs for consistent UI - [`079a065`](https://github.com/karakeep-app/karakeep/commit/079a065ba621cb6561bc59fdb2215e9e2c83f103) refactor: align tab bars and adjust content padding in BookmarkPreview - [`e10d959`](https://github.com/karakeep-app/karakeep/commit/e10d959ccef52cb57536fc329686c7cb096d8e4d) UI enh: action bar should be higher - [`f2ce580`](https://github.com/karakeep-app/karakeep/commit/f2ce580086947a738a5935b06165d6e80fe0bd79) style: increase action bar button spacing for better touch interaction - [`5bcea76`](https://github.com/karakeep-app/karakeep/commit/5bcea76019b90087976fd4cef0ef68f4b18b1db5) feat: increase modal size to reduce wasted space in bookmark preview - [`9faf86f`](https://github.com/karakeep-app/karakeep/commit/9faf86ff8270224b0854c46b92b5eab3d0d79824) fix: prevent text selection on tab buttons in BookmarkPreview ### 📊 Changes **4 files changed** (+63 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/app/dashboard/@modal/(.)preview/[bookmarkId]/page.tsx` (+1 -1) 📝 `apps/web/components/dashboard/preview/ActionBar.tsx` (+1 -1) 📝 `apps/web/components/dashboard/preview/BookmarkPreview.tsx` (+4 -4) 📝 `apps/web/components/dashboard/preview/LinkContentSection.tsx` (+57 -53) </details> ### 📄 Description This is a continuation of #1425, where now I added a tab bar to choose between "reader view", "archive", etc. I had to add an ellipsis mechanism in case the UI is super scaled up, otherwise there were overlapping button labels. Feedback much appreciated! ![Screenshot_20250527-003909_1](https://github.com/user-attachments/assets/a0d69cbb-e962-43cd-a2cb-aa5c0dedcb19) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 11:59:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1834
No description provided.