[PR #1392] [MERGED] fix(search): add new relevance sort order #1813

New issue

Closed

opened 2026-03-02 11:59:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1392
Author: @xuatz
Created: 5/11/2025
Status: ✅ Merged
Merged: 5/18/2025
Merged by: @MohamedBassem

Base: main ← Head: fix/tag-search-sort

📝 Commits (3)

1fa4378 fix(search): add new relevance sort order
819217f address pr comments
8a0e3bb some minor fixes

📊 Changes

7 files changed (+74 additions, -16 deletions)

View changed files

📝 apps/web/app/dashboard/search/page.tsx (+9 -1)
📝 apps/web/components/dashboard/SortOrderToggle.tsx (+30 -6)
📝 apps/web/components/dashboard/bookmarks/UpdatableBookmarksGrid.tsx (+5 -1)
📝 apps/web/lib/hooks/bookmark-search.ts (+7 -2)
📝 apps/web/lib/i18n/locales/en/translation.json (+1 -0)
📝 packages/shared/types/bookmarks.ts (+3 -3)
📝 packages/trpc/routers/bookmarks.ts (+19 -3)

📄 Description

Summary

add new sort order relevance
retain existing(legacy) search's sort logic as relevance
add new asc and desc sort logic

fixes #1335

Notes

I'm wasn't super sure how karakeep handles the translation, so let me know if there are follow up tasks, and anything else that I should tweak for this PR, thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1392 **Author:** [@xuatz](https://github.com/xuatz) **Created:** 5/11/2025 **Status:** ✅ Merged **Merged:** 5/18/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `fix/tag-search-sort` --- ### 📝 Commits (3) - [`1fa4378`](https://github.com/karakeep-app/karakeep/commit/1fa4378542ff5739bbe4be619a5043a481b32ce8) fix(search): add new relevance sort order - [`819217f`](https://github.com/karakeep-app/karakeep/commit/819217f84c008d6c96800fc8e96e2bb7b8ab05fd) address pr comments - [`8a0e3bb`](https://github.com/karakeep-app/karakeep/commit/8a0e3bb3f1f726b2817957c4ff12f8e622e40bda) some minor fixes ### 📊 Changes **7 files changed** (+74 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/app/dashboard/search/page.tsx` (+9 -1) 📝 `apps/web/components/dashboard/SortOrderToggle.tsx` (+30 -6) 📝 `apps/web/components/dashboard/bookmarks/UpdatableBookmarksGrid.tsx` (+5 -1) 📝 `apps/web/lib/hooks/bookmark-search.ts` (+7 -2) 📝 `apps/web/lib/i18n/locales/en/translation.json` (+1 -0) 📝 `packages/shared/types/bookmarks.ts` (+3 -3) 📝 `packages/trpc/routers/bookmarks.ts` (+19 -3) </details> ### 📄 Description ## Summary * add new sort order `relevance` * retain existing(legacy) search's sort logic as `relevance` * add new `asc` and `desc` sort logic fixes #1335 ## Notes I'm wasn't super sure how karakeep handles the translation, so let me know if there are follow up tasks, and anything else that I should tweak for this PR, thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:17 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1813

No description provided.

Rows
Columns