[PR #1297] Feat/playwright chromium vnc #1793

Open
opened 2026-03-02 11:59:12 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1297
Author: @maelp
Created: 4/21/2025
Status: 🔄 Open

Base: mainHead: feat/playwright-chromium-vnc


📝 Commits (5)

  • 806c5ce feat: convert to playwright
  • 503df35 feat: convert from Puppeteer to Playwright for crawling
  • 2ce5f3f feat: update docker-compose
  • fbd7ece feat: use chromium-vnc docker image for improved debugging
  • 1422e23 feat: add cookies from the VNC chromium

📊 Changes

6 files changed (+241 additions, -751 deletions)

View changed files

📝 apps/workers/crawlerWorker.ts (+142 -49)
📝 apps/workers/package.json (+2 -4)
📝 docker/Dockerfile (+1 -1)
📝 docker/Dockerfile.dev (+1 -1)
📝 docker/docker-compose.dev.yml (+9 -8)
📝 pnpm-lock.yaml (+86 -688)

📄 Description

This should be merged on top of the playwright branch, to add the VNC + chromium + cookie sharing

if you deploy this, you would need to secure the VNC access using VNC_PASSWORD=some-strong-password so that people can't connect to it (or don't expose it and just use a SSH tunnel / Tailscale to access it)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1297 **Author:** [@maelp](https://github.com/maelp) **Created:** 4/21/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/playwright-chromium-vnc` --- ### 📝 Commits (5) - [`806c5ce`](https://github.com/karakeep-app/karakeep/commit/806c5ce5737859ed13b0e0b253aba5ebbf5830c4) feat: convert to playwright - [`503df35`](https://github.com/karakeep-app/karakeep/commit/503df35d387db0330868089be92f05e536a0deff) feat: convert from Puppeteer to Playwright for crawling - [`2ce5f3f`](https://github.com/karakeep-app/karakeep/commit/2ce5f3f794e7bc74e8ed1ca28f28d6e32f52b33b) feat: update docker-compose - [`fbd7ece`](https://github.com/karakeep-app/karakeep/commit/fbd7ece4bcea86ec4667e3f6cdda972ed60f3c04) feat: use chromium-vnc docker image for improved debugging - [`1422e23`](https://github.com/karakeep-app/karakeep/commit/1422e23c9b725b1df28c39473b81dd41b318b19c) feat: add cookies from the VNC chromium ### 📊 Changes **6 files changed** (+241 additions, -751 deletions) <details> <summary>View changed files</summary> 📝 `apps/workers/crawlerWorker.ts` (+142 -49) 📝 `apps/workers/package.json` (+2 -4) 📝 `docker/Dockerfile` (+1 -1) 📝 `docker/Dockerfile.dev` (+1 -1) 📝 `docker/docker-compose.dev.yml` (+9 -8) 📝 `pnpm-lock.yaml` (+86 -688) </details> ### 📄 Description This should be merged on top of the playwright branch, to add the VNC + chromium + cookie sharing if you deploy this, you would need to secure the VNC access using VNC_PASSWORD=some-strong-password so that people can't connect to it (or don't expose it and just use a SSH tunnel / Tailscale to access it) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1793
No description provided.