[PR #1005] [MERGED] fix: add header class name corresponding to dark mode for text color #1726

New issue

Closed

opened 2026-03-02 11:58:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:58:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1005
Author: @saadmanfarhad
Created: 2/9/2025
Status: ✅ Merged
Merged: 2/9/2025
Merged by: @MohamedBassem

Base: main ← Head: fix/mobile-dark-mode-navigation-button-and-title-color

📝 Commits (1)

af9357c fix: add header class name corresponding to dark mode for text color

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 apps/mobile/app/dashboard/_layout.tsx (+1 -0)

📄 Description

Why

The color for the navigation back button and navigation title in dark mode is not adapted and therefore cannot be differentiated from the dark background. Below, I'm sharing some before after screenshots to make the issue more easier to grasp.

Before

After

This PR attempts at fixing the bug: https://github.com/hoarder-app/hoarder/issues/829

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1005 **Author:** [@saadmanfarhad](https://github.com/saadmanfarhad) **Created:** 2/9/2025 **Status:** ✅ Merged **Merged:** 2/9/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `fix/mobile-dark-mode-navigation-button-and-title-color` --- ### 📝 Commits (1) - [`af9357c`](https://github.com/karakeep-app/karakeep/commit/af9357c5a881492f7314d774c3a4ae8cff0561cc) fix: add header class name corresponding to dark mode for text color ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `apps/mobile/app/dashboard/_layout.tsx` (+1 -0) </details> ### 📄 Description ## Why The color for the navigation back button and navigation title in dark mode is not adapted and therefore cannot be differentiated from the dark background. Below, I'm sharing some before after screenshots to make the issue more easier to grasp. ## Before ![Screenshot_2025-02-09-18-51-45-05_f73b71075b1de7323614b647fe394240](https://github.com/user-attachments/assets/f3013d2d-b1e7-4f0f-8561-85eebb92911b) ![Screenshot_2025-02-09-18-51-20-87_f73b71075b1de7323614b647fe394240](https://github.com/user-attachments/assets/9a4f249b-e695-40a2-a413-6a9dc89365c5) ## After ![Screenshot_2025-02-09-19-00-21-56_f73b71075b1de7323614b647fe394240](https://github.com/user-attachments/assets/d2996e1b-3916-49b2-81f6-6eee3008303b) ![Screenshot_2025-02-09-19-00-09-30_f73b71075b1de7323614b647fe394240](https://github.com/user-attachments/assets/8aa36c77-7ad9-457a-956a-a33f800df934) This PR attempts at fixing the bug: https://github.com/hoarder-app/hoarder/issues/829 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:58:54 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1726

No description provided.

Rows
Columns