[PR #787] [MERGED] improvement: add confirmation before deleting item #1693

New issue

Closed

opened 2026-03-02 11:58:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:58:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/787
Author: @lexafaxine
Created: 12/30/2024
Status: ✅ Merged
Merged: 12/31/2024
Merged by: @MohamedBassem

Base: main ← Head: delete-bookmark-confirmation

📝 Commits (1)

5460f44 add delete bookmark confirmation dialog

📊 Changes

6 files changed (+110 additions, -38 deletions)

View changed files

📝 apps/mobile/components/bookmarks/BookmarkCard.tsx (+16 -3)
📝 apps/web/components/dashboard/bookmarks/BookmarkOptions.tsx (+9 -12)
➕ apps/web/components/dashboard/bookmarks/DeleteBookmarkConfirmationDialog.tsx (+63 -0)
📝 apps/web/components/dashboard/preview/ActionBar.tsx (+15 -22)
📝 apps/web/lib/i18n/locales/en/translation.json (+6 -0)
📝 pnpm-lock.yaml (+1 -1)

📄 Description

PR for #776

For mobile,
added an alert when deleting bookmark

For web,
added an confirmation dialog when deleting bookmark

Proof:
https://drive.google.com/drive/folders/1067NHRKKIoip3vZRfgaJnbxBj1XHf5oc?usp=sharing

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/787 **Author:** [@lexafaxine](https://github.com/lexafaxine) **Created:** 12/30/2024 **Status:** ✅ Merged **Merged:** 12/31/2024 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `delete-bookmark-confirmation` --- ### 📝 Commits (1) - [`5460f44`](https://github.com/karakeep-app/karakeep/commit/5460f44147e30c29a9b6b2d4eff5bfb82efa7a7b) add delete bookmark confirmation dialog ### 📊 Changes **6 files changed** (+110 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `apps/mobile/components/bookmarks/BookmarkCard.tsx` (+16 -3) 📝 `apps/web/components/dashboard/bookmarks/BookmarkOptions.tsx` (+9 -12) ➕ `apps/web/components/dashboard/bookmarks/DeleteBookmarkConfirmationDialog.tsx` (+63 -0) 📝 `apps/web/components/dashboard/preview/ActionBar.tsx` (+15 -22) 📝 `apps/web/lib/i18n/locales/en/translation.json` (+6 -0) 📝 `pnpm-lock.yaml` (+1 -1) </details> ### 📄 Description PR for #776 For mobile, added an alert when deleting bookmark For web, added an confirmation dialog when deleting bookmark Proof: https://drive.google.com/drive/folders/1067NHRKKIoip3vZRfgaJnbxBj1XHf5oc?usp=sharing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:58:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1693

No description provided.

Rows
Columns