[PR #243] [MERGED] [Bug] Fix save action on empty card #1572

Closed
opened 2026-03-02 11:58:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/243
Author: @mdsaban
Created: 6/20/2024
Status: Merged
Merged: 6/22/2024
Merged by: @MohamedBassem

Base: mainHead: fix-save-action


📝 Commits (4)

  • 3728fec fix: Empty item save action
  • 1df9a5d fix: resolve comments
  • 825e990 chore: prettier
  • 931f822 Merge branch 'main' into fix-save-action

📊 Changes

3 files changed (+36 additions, -5 deletions)

View changed files

📝 apps/web/components/dashboard/bookmarks/EditorCard.tsx (+7 -4)
📝 apps/web/components/ui/info-tooltip.tsx (+5 -1)
📝 apps/web/lib/utils.ts (+24 -0)

📄 Description

What?

  • Fixes save action on empty card. Currently if user clicks on save button, then it creates empty card
  • Improves UI a little bit of the editor card

Screenshot

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/243 **Author:** [@mdsaban](https://github.com/mdsaban) **Created:** 6/20/2024 **Status:** ✅ Merged **Merged:** 6/22/2024 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `fix-save-action` --- ### 📝 Commits (4) - [`3728fec`](https://github.com/karakeep-app/karakeep/commit/3728fec1ea6f74e83f8f9e5c16802d27536759e1) fix: Empty item save action - [`1df9a5d`](https://github.com/karakeep-app/karakeep/commit/1df9a5db245ef3c6c9b5b412bb836baf45d17813) fix: resolve comments - [`825e990`](https://github.com/karakeep-app/karakeep/commit/825e990b421b685b73b6b65d36ca6639c6779a21) chore: prettier - [`931f822`](https://github.com/karakeep-app/karakeep/commit/931f82263899311a3452f64c59c99123f73549f9) Merge branch 'main' into fix-save-action ### 📊 Changes **3 files changed** (+36 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/components/dashboard/bookmarks/EditorCard.tsx` (+7 -4) 📝 `apps/web/components/ui/info-tooltip.tsx` (+5 -1) 📝 `apps/web/lib/utils.ts` (+24 -0) </details> ### 📄 Description ## What? - Fixes save action on empty card. Currently if user clicks on save button, then it creates empty card - Improves UI a little bit of the editor card ## Screenshot <img width="1085" alt="image" src="https://github.com/hoarder-app/hoarder/assets/45597394/72ab4a48-b4f8-4de4-8c1f-1830002f8e94"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 11:58:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1572
No description provided.