[PR #21] [CLOSED] Fix #18 #32

New issue

Closed

opened 2026-03-02 05:08:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 05:08:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/goodhosts/hostsfile/pull/21
Author: @tomjn
Created: 11/5/2021
Status: ❌ Closed

Base: master ← Head: patch-3

📝 Commits (1)

8e7dd11 Fix #18

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 hosts.go (+1 -0)

📄 Description

Second attempt at trying to fix this that hopefully addresses the feedback from my last attempt.

The issue being that the only time it checks how many are on the same line is during a clean, otherwise it doesn't check this during the Add routine allowing it to happen sometimes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/goodhosts/hostsfile/pull/21 **Author:** [@tomjn](https://github.com/tomjn) **Created:** 11/5/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-3` --- ### 📝 Commits (1) - [`8e7dd11`](https://github.com/goodhosts/hostsfile/commit/8e7dd11ae757524a6f174c0195f3d94518c4fa52) Fix #18 ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `hosts.go` (+1 -0) </details> ### 📄 Description Second attempt at trying to fix this that hopefully addresses the feedback from my last attempt. The issue being that the only time it checks how many are on the same line is during a clean, otherwise it doesn't check this during the Add routine allowing it to happen sometimes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>