[GH-ISSUE #55] Feature Request: Method to Create Hostsfile from String #18

Open
opened 2026-03-02 05:08:09 +03:00 by kerem · 2 comments
Owner

Originally created by @spencercjh on GitHub (Jun 25, 2024).
Original GitHub issue: https://github.com/goodhosts/hostsfile/issues/55

I would like to express my gratitude for your contributions to the project. The two New methods for reading from a file are extremely convenient and useful in my work.

However, I've encountered a scenario where I need to read the contents of a hostsfile stored in memory. My workaround is to write the in-memory hostsfile to a temporary file and then use the existing API to read it. This process is not ideal and could be streamlined.

Therefore, I would like to propose a new feature: a NewHostsFromStr method that allows the creation of a hostsfile directly from a string. Maybe we can just expose the existing test method loadString?

If this proposal aligns with the project's goals, I want to contribute to its implementation. I look forward to hearing your thoughts on this suggestion.

Thank you for considering my proposal.

Originally created by @spencercjh on GitHub (Jun 25, 2024). Original GitHub issue: https://github.com/goodhosts/hostsfile/issues/55 I would like to express my gratitude for your contributions to the project. The two `New` methods for reading from a file are extremely convenient and useful in my work. However, I've encountered a scenario where I need to read the contents of a hostsfile stored in memory. My workaround is to write the in-memory hostsfile to a temporary file and then use the existing API to read it. This process is not ideal and could be streamlined. Therefore, I would like to propose a new feature: a `NewHostsFromStr` method that allows the creation of a hostsfile directly from a string. Maybe we can just expose the existing test method `loadString`? If this proposal aligns with the project's goals, I want to contribute to its implementation. I look forward to hearing your thoughts on this suggestion. Thank you for considering my proposal.
Author
Owner

@luthermonson commented on GitHub (Jun 25, 2024):

only concern i have with exposing it is probably all the funcs which need a file path to work e.g. IsWritable and Flush. Would you expect to set the Path yourself for those to work or would NewHostsFromStr take two params, the string and the path where you eventually want it?

<!-- gh-comment-id:2189401949 --> @luthermonson commented on GitHub (Jun 25, 2024): only concern i have with exposing it is probably all the funcs which need a file path to work e.g. `IsWritable` and `Flush`. Would you expect to set the `Path` yourself for those to work or would `NewHostsFromStr` take two params, the string and the path where you eventually want it?
Author
Owner

@spencercjh commented on GitHub (Jul 1, 2024):

only concern i have with exposing it is probably all the funcs which need a file path to work e.g. IsWritable and Flush. Would you expect to set the Path yourself for those to work or would NewHostsFromStr take two params, the string and the path where you eventually want it?

I got your points. This may require reimplementing all the existing interfaces all over again.

<!-- gh-comment-id:2199437598 --> @spencercjh commented on GitHub (Jul 1, 2024): > only concern i have with exposing it is probably all the funcs which need a file path to work e.g. `IsWritable` and `Flush`. Would you expect to set the `Path` yourself for those to work or would `NewHostsFromStr` take two params, the string and the path where you eventually want it? I got your points. This may require reimplementing all the existing interfaces all over again.
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hostsfile#18
No description provided.