mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #227] Credentials are still being included in Permalink even when "Include in URL" is turned off #80
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#80
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @reefqi037 on GitHub (Oct 29, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/227
Describe the bug
Include in URLtoggle only include/excludeauthparameter.To Reproduce
Steps to reproduce the behavior:
Authentication TypetoBasicorBearer TokenUsernameandPasswordorTokenInclude in URLbutton on and offhttpUserandhttpPasswordorbearerTokenleft in URLExpected behavior
Include in URLtoggle button should include/exclude not onlyauth, buthttpUser,httpPasswordandbearerTokentoo.Screenshots

Additional context
Related with #178 and #215
@NBTX commented on GitHub (Oct 29, 2019):
Ah! I know the cause, I'll submit a PR as soon as I get home.
@reefqi037 commented on GitHub (Oct 29, 2019):
Yeah, thought you will figured it out since you wrote that part. I have submit a PR too but feel free to make another. I'm new to vue and still learning 😬
@NBTX commented on GitHub (Oct 29, 2019):
Nope your PR works fine!