[GH-ISSUE #1891] Html preview view area is not full height #602

Closed
opened 2026-03-16 16:19:31 +03:00 by kerem · 11 comments
Owner

Originally created by @iagormoraes on GitHub (Oct 21, 2021).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1891

Originally assigned to: @rishabhkalra96, @iagormoraes on GitHub.

Describe the bug
By getting a HTML response from any endpoint call, the preview is not getting the full height of available space as shown in the screenshot.

To Reproduce
Steps to reproduce the behavior:

  1. Make request to https://github.com/hoppscotch/hoppscotch/issues
  2. Click on Show Preview
  3. You should see the height of the preview not fitting the available space

Expected behavior
The users should be able to see the preview in full height of available space.

Screenshots
Screen Shot 2021-10-21 at 08 18 35

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Safari
  • Version 2.0

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Originally created by @iagormoraes on GitHub (Oct 21, 2021). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1891 Originally assigned to: @rishabhkalra96, @iagormoraes on GitHub. **Describe the bug** By getting a HTML response from any endpoint call, the preview is not getting the full height of available space as shown in the screenshot. **To Reproduce** Steps to reproduce the behavior: 1. Make request to `https://github.com/hoppscotch/hoppscotch/issues` 2. Click on `Show Preview` 3. You should see the height of the preview not fitting the available space **Expected behavior** The users should be able to see the preview in full height of available space. **Screenshots** <img width="1679" alt="Screen Shot 2021-10-21 at 08 18 35" src="https://user-images.githubusercontent.com/13892132/138268136-4dd0953e-34cb-4d35-8837-deed57b40e57.png"> **Desktop (please complete the following information):** - OS: MacOS - Browser Safari - Version 2.0 **Smartphone (please complete the following information):** - Device: [e.g. iPhone6] - OS: [e.g. iOS8.1] - Browser [e.g. stock browser, safari] - Version [e.g. 22] **Additional context** Add any other context about the problem here.
kerem 2026-03-16 16:19:31 +03:00
Author
Owner

@liyasthomas commented on GitHub (Oct 21, 2021):

Hi @iagormoraes, thanks for reporting this behavior. We'll look into fixing this as soon as possible.

<!-- gh-comment-id:948523615 --> @liyasthomas commented on GitHub (Oct 21, 2021): Hi @iagormoraes, thanks for reporting this behavior. We'll look into fixing this as soon as possible.
Author
Owner

@rishabhkalra96 commented on GitHub (Oct 22, 2021):

hi @liyasthomas , would like to take up this issue.

<!-- gh-comment-id:949352250 --> @rishabhkalra96 commented on GitHub (Oct 22, 2021): hi @liyasthomas , would like to take up this issue.
Author
Owner

@liyasthomas commented on GitHub (Oct 22, 2021):

Hi @rishabhkalra96, feel free to pick this up. Assigning it to you.

<!-- gh-comment-id:949361992 --> @liyasthomas commented on GitHub (Oct 22, 2021): Hi @rishabhkalra96, feel free to pick this up. Assigning it to you.
Author
Owner

@liyasthomas commented on GitHub (Nov 3, 2021):

Hi @rishabhkalra96, let me know if you've any trouble with this issue. Would love to help you out.

<!-- gh-comment-id:958654104 --> @liyasthomas commented on GitHub (Nov 3, 2021): Hi @rishabhkalra96, let me know if you've any trouble with this issue. Would love to help you out.
Author
Owner

@iagormoraes commented on GitHub (Nov 3, 2021):

I can help also in this issue, just let me know 🙂

<!-- gh-comment-id:959733869 --> @iagormoraes commented on GitHub (Nov 3, 2021): I can help also in this issue, just let me know 🙂
Author
Owner

@AndrewBastin commented on GitHub (Nov 3, 2021):

@iagormoraes sure you can work on this!

<!-- gh-comment-id:959804305 --> @AndrewBastin commented on GitHub (Nov 3, 2021): @iagormoraes sure you can work on this!
Author
Owner

@iagormoraes commented on GitHub (Nov 3, 2021):

I can't run dev due to some error of package, followed the development steps to setup the project, I saw we use workspaces for it but it seems to be not recognizing it:

packages/hoppscotch-app do-dev$ pnpm run dev
[99 lines collapsed]
│ [dev:nuxt       ]  WARN  in /workspace/hoppscotch/node_modules/.pnpm/yargs-parser@20.2.9/node_modules/yargs-parser/build/lib/index.js
│ [dev:nuxt       ] 
│ [dev:nuxt       ] 
│ [dev:nuxt       ]  ERROR  Failed to compile with 1 errors
│ [dev:nuxt       ] 
│ [dev:nuxt       ] This dependency was not found:
│ [dev:nuxt       ] 
│ [dev:nuxt       ] * @hoppscotch/js-sandbox in ./helpers/RequestRunner.ts
│ [dev:nuxt       ] 
│ [dev:nuxt       ] To install it, you can run: npm install --save @hoppscotch/js-sandbox
└─ Running...

It happens both local and in cloud with Gitpod, someone knows that?

<!-- gh-comment-id:960017612 --> @iagormoraes commented on GitHub (Nov 3, 2021): I can't run dev due to some error of package, followed the development steps to setup the project, I saw we use workspaces for it but it seems to be not recognizing it: ``` packages/hoppscotch-app do-dev$ pnpm run dev [99 lines collapsed] │ [dev:nuxt ] WARN in /workspace/hoppscotch/node_modules/.pnpm/yargs-parser@20.2.9/node_modules/yargs-parser/build/lib/index.js │ [dev:nuxt ] │ [dev:nuxt ] │ [dev:nuxt ] ERROR Failed to compile with 1 errors │ [dev:nuxt ] │ [dev:nuxt ] This dependency was not found: │ [dev:nuxt ] │ [dev:nuxt ] * @hoppscotch/js-sandbox in ./helpers/RequestRunner.ts │ [dev:nuxt ] │ [dev:nuxt ] To install it, you can run: npm install --save @hoppscotch/js-sandbox └─ Running... ``` It happens both local and in cloud with Gitpod, someone knows that?
Author
Owner

@liyasthomas commented on GitHub (Nov 4, 2021):

This seems like an issue with the Node environment. To set up Hoppscotch development you might need to upgrade the Node version to v14.x or above. Let me know if this doesn't help - try cleaning the node_modules directory and reinstalling dependencies.

EDIT:
By the way, you'll need to install the dependencies and run pnpm run dev from root directory probably hoppscotch, not hoppscotch/packages/hoppscotch-app.

<!-- gh-comment-id:960456553 --> @liyasthomas commented on GitHub (Nov 4, 2021): This seems like an issue with the Node environment. To set up Hoppscotch development you might need to upgrade the Node version to v14.x or above. Let me know if this doesn't help - try cleaning the `node_modules` directory and reinstalling dependencies. EDIT: By the way, you'll need to install the dependencies and run `pnpm run dev` from root directory probably `hoppscotch`, not `hoppscotch/packages/hoppscotch-app`.
Author
Owner

@iagormoraes commented on GitHub (Nov 4, 2021):

This seems like an issue with the Node environment. To set up Hoppscotch development you might need to upgrade the Node version to v14.x or above. Let me know if this doesn't help - try cleaning the node_modules directory and reinstalling dependencies.

EDIT: By the way, you'll need to install the dependencies and run pnpm run dev from root directory probably hoppscotch, not hoppscotch/packages/hoppscotch-app.

Hey @liyasthomas I've just tried that and still complains the missing package, is interesting because in node_modules I can see the folder there but it seems to not being recognized, even in Webstorm IDE, any tips?

I'm using node 16.13.0 LTS

<!-- gh-comment-id:961220747 --> @iagormoraes commented on GitHub (Nov 4, 2021): > This seems like an issue with the Node environment. To set up Hoppscotch development you might need to upgrade the Node version to v14.x or above. Let me know if this doesn't help - try cleaning the `node_modules` directory and reinstalling dependencies. > > EDIT: By the way, you'll need to install the dependencies and run `pnpm run dev` from root directory probably `hoppscotch`, not `hoppscotch/packages/hoppscotch-app`. Hey @liyasthomas I've just tried that and still complains the missing package, is interesting because in `node_modules` I can see the folder there but it seems to not being recognized, even in Webstorm IDE, any tips? I'm using node 16.13.0 LTS
Author
Owner

@liyasthomas commented on GitHub (Nov 4, 2021):

There was an issue in Windows OS which might've caused this behavior. This has been patched - pull the latest main branch or reclone the repository and try again. Let us know if the issue persists.

<!-- gh-comment-id:961226400 --> @liyasthomas commented on GitHub (Nov 4, 2021): There was an issue in Windows OS which might've caused this behavior. This has been patched - pull the latest `main` branch or reclone the repository and try again. Let us know if the issue persists.
Author
Owner

@iagormoraes commented on GitHub (Nov 4, 2021):

There was an issue in Windows OS which might've caused this behavior. This has been patched - pull the latest main branch or reclone the repository and try again. Let us know if the issue persists.

I pulled and is working now.

<!-- gh-comment-id:961236165 --> @iagormoraes commented on GitHub (Nov 4, 2021): > There was an issue in Windows OS which might've caused this behavior. This has been patched - pull the latest `main` branch or reclone the repository and try again. Let us know if the issue persists. I pulled and is working now.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#602
No description provided.