[PR #602] [MERGED] GraphQL page improvements, and more #2739

New issue

Closed

opened 2026-03-17 00:24:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:24:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/602
Author: @dihmeetree
Created: 2/25/2020
Status: ✅ Merged
Merged: 2/26/2020
Merged by: @liyasthomas

Base: master ← Head: feature/fix-gql-state

📝 Commits (10+)

21c6c07 Save GraphQL schema and response in state
403254a Change from v-model to value as this is not set by the user
a3d6573 Save collapsed sections to state
e233e9b Merge branch 'master' into feature/fix-gql-state
7c23cd7 Add loading message in response box for "Run query" action
62a970e Fix auto scroll
0eab54c Set showExtensionsToast to false in local storage if no is clicked
1d616c7 Fix: Set showExtensionsToast to false in local storage if no is clicked
90d347d Disable spell check on input fields
b8ba6e3 Re-trigger build

📊 Changes

12 files changed (+283 additions, -214 deletions)

View changed files

➖ .huskyrc (+0 -5)
➖ .prettierrc (+0 -6)
📝 components/ace-editor.vue (+47 -44)
📝 components/section.vue (+11 -9)
📝 functions/jsonParse.js (+125 -125)
📝 layouts/default.vue (+10 -1)
📝 package.json (+11 -0)
📝 pages/graphql.vue (+55 -22)
📝 pages/index.vue (+12 -2)
📝 pages/realtime.vue (+1 -0)
📝 store/mutations.js (+6 -0)
📝 store/state.js (+5 -0)

📄 Description

This PR does the following:

Saves the schema and response to the local state, so if you refresh or navigate to a new page and back, it will show up again. https://github.com/liyasthomas/postwoman/pull/602/commits/21c6c07b3970252f10e3a5269e8372991b7dd2ca
Update the Run Query button so it matches the Get schema button
Running a query now shows "Loading..." in the response section, similar to when you click "Get Schema" https://github.com/liyasthomas/postwoman/pull/602/commits/ab49a125b290b760c3a8c70bddd9b94c9eb566a5
Saves collapsed sections to the local state, similarly to the schema and response, Postwoman will show sections collapsed if you refresh/navigate away. (This will work on all pages; Not just the GraphQL page, as it uses the route as a key) https://github.com/liyasthomas/postwoman/pull/602/commits/2d5b70ab8511c3ee46a8fb76f1a3aec386f5e376
Fixes auto scroll toggle (While I don't necessarily agree with how settings are initialized in the store; I've added checks for undefined auto scroll keys) https://github.com/liyasthomas/postwoman/pull/602/commits/6d534d312f06ead99d932072fe677194cbfb2963
(Fix) Set showExtensionsToast to false in localStorage when no is clicked on the extensions toast https://github.com/liyasthomas/postwoman/pull/602/commits/1d616c7ec6bc6149edb17d8e94592c114e3d33e2
Disable spell check on input fields (Shows red line under text if spell check is enabled)
(Fix) Error message for failed queries/mutations on GraphQL page
(Fix) Disable json linting for response editor on GraphQL page https://github.com/liyasthomas/postwoman/pull/605#issuecomment-591197382
Moved .prettierrc and .huskyrc contents to the package.json file, so we have 2 less files to manage https://github.com/liyasthomas/postwoman/pull/602/commits/50339a2480205cd46c866aa314cb57d8d689b9c0

Note: I haven't gotten around to saving the types/queries/mutation to the local state yet (the Docs) But I will get to that soon :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/602 **Author:** [@dihmeetree](https://github.com/dihmeetree) **Created:** 2/25/2020 **Status:** ✅ Merged **Merged:** 2/26/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `feature/fix-gql-state` --- ### 📝 Commits (10+) - [`21c6c07`](https://github.com/hoppscotch/hoppscotch/commit/21c6c07b3970252f10e3a5269e8372991b7dd2ca) Save GraphQL schema and response in state - [`403254a`](https://github.com/hoppscotch/hoppscotch/commit/403254a983986b8afa20435b0a48f496c06c9637) Change from v-model to value as this is not set by the user - [`a3d6573`](https://github.com/hoppscotch/hoppscotch/commit/a3d6573d93281d1529fcae117cbd79a6b755df5e) Save collapsed sections to state - [`e233e9b`](https://github.com/hoppscotch/hoppscotch/commit/e233e9be16bab048979093294df6e3abdb8fcc2d) Merge branch 'master' into feature/fix-gql-state - [`7c23cd7`](https://github.com/hoppscotch/hoppscotch/commit/7c23cd7c4ccbec7ac514dc827a20fa3414230444) Add loading message in response box for "Run query" action - [`62a970e`](https://github.com/hoppscotch/hoppscotch/commit/62a970e8c32588d138fbb0c0042a3f6fe5683ec8) Fix auto scroll - [`0eab54c`](https://github.com/hoppscotch/hoppscotch/commit/0eab54cbdce44f2c3af9a97934678ca175729ba7) Set showExtensionsToast to false in local storage if no is clicked - [`1d616c7`](https://github.com/hoppscotch/hoppscotch/commit/1d616c7ec6bc6149edb17d8e94592c114e3d33e2) Fix: Set showExtensionsToast to false in local storage if no is clicked - [`90d347d`](https://github.com/hoppscotch/hoppscotch/commit/90d347dc89c8a3680db786b797b00afea082ace0) Disable spell check on input fields - [`b8ba6e3`](https://github.com/hoppscotch/hoppscotch/commit/b8ba6e39e20ec9aaf805d6271cd51ba3aa90fafe) Re-trigger build ### 📊 Changes **12 files changed** (+283 additions, -214 deletions) <details> <summary>View changed files</summary> ➖ `.huskyrc` (+0 -5) ➖ `.prettierrc` (+0 -6) 📝 `components/ace-editor.vue` (+47 -44) 📝 `components/section.vue` (+11 -9) 📝 `functions/jsonParse.js` (+125 -125) 📝 `layouts/default.vue` (+10 -1) 📝 `package.json` (+11 -0) 📝 `pages/graphql.vue` (+55 -22) 📝 `pages/index.vue` (+12 -2) 📝 `pages/realtime.vue` (+1 -0) 📝 `store/mutations.js` (+6 -0) 📝 `store/state.js` (+5 -0) </details> ### 📄 Description This PR does the following: - Saves the schema and response to the local state, so if you refresh or navigate to a new page and back, it will show up again. https://github.com/liyasthomas/postwoman/pull/602/commits/21c6c07b3970252f10e3a5269e8372991b7dd2ca - Update the `Run Query` button so it matches the `Get schema` button ![image](https://user-images.githubusercontent.com/20114263/75215425-a8472a80-575e-11ea-8856-cd081cf9c878.png) - Running a query now shows "Loading..." in the response section, similar to when you click "Get Schema" https://github.com/liyasthomas/postwoman/pull/602/commits/ab49a125b290b760c3a8c70bddd9b94c9eb566a5 - Saves collapsed sections to the local state, similarly to the schema and response, Postwoman will show sections collapsed if you refresh/navigate away. (This will work on all pages; Not just the GraphQL page, as it uses the route as a key) https://github.com/liyasthomas/postwoman/pull/602/commits/2d5b70ab8511c3ee46a8fb76f1a3aec386f5e376 - Fixes auto scroll toggle (While I don't necessarily agree with how settings are initialized in the store; I've added checks for undefined auto scroll keys) https://github.com/liyasthomas/postwoman/pull/602/commits/6d534d312f06ead99d932072fe677194cbfb2963 - (Fix) Set `showExtensionsToast` to false in localStorage when no is clicked on the extensions toast https://github.com/liyasthomas/postwoman/pull/602/commits/1d616c7ec6bc6149edb17d8e94592c114e3d33e2 - Disable spell check on input fields (Shows red line under text if spell check is enabled) - (Fix) Error message for failed queries/mutations on GraphQL page - (Fix) Disable json linting for response editor on GraphQL page https://github.com/liyasthomas/postwoman/pull/605#issuecomment-591197382 - Moved `.prettierrc` and `.huskyrc` contents to the `package.json` file, so we have 2 less files to manage https://github.com/liyasthomas/postwoman/pull/602/commits/50339a2480205cd46c866aa314cb57d8d689b9c0 **Note**: I haven't gotten around to saving the types/queries/mutation to the local state yet (the Docs) But I will get to that soon :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>