[PR #5084] [MERGED] fix: include request body to AWS V4 signer in effective request functions #5048

New issue

Closed

opened 2026-03-17 02:31:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:31:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5084
Author: @anwarulislam
Created: 5/19/2025
Status: ✅ Merged
Merged: 5/21/2025
Merged by: @jamesgeorge007

Base: next ← Head: fix/awsv4body

📝 Commits (1)

3374a81 chore: add body parameter to AWS V4 signer in effective request functions

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-cli/src/utils/pre-request.ts (+3 -0)
📝 packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts (+4 -0)

📄 Description

Closes #5064

What's changed

This pull request addresses issue #5084 by modifying the effective request functions to include the request body when signing requests with AWS V4. This enhancement ensures that the request signature is generated accurately, taking into account the content of the request body, which is crucial for the integrity and security of the requests made to AWS services.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5084 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 5/19/2025 **Status:** ✅ Merged **Merged:** 5/21/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/awsv4body` --- ### 📝 Commits (1) - [`3374a81`](https://github.com/hoppscotch/hoppscotch/commit/3374a813c03ee3364cfa930fbb8a04e98614da47) chore: add body parameter to AWS V4 signer in effective request functions ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-cli/src/utils/pre-request.ts` (+3 -0) 📝 `packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts` (+4 -0) </details> ### 📄 Description Closes #5064 ### What's changed This pull request addresses issue #5084 by modifying the effective request functions to include the request body when signing requests with AWS V4. This enhancement ensures that the request signature is generated accurately, taking into account the content of the request body, which is crucial for the integrity and security of the requests made to AWS services. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>