[PR #5158] fix: update environment variables immediately after pre-request scrip… #5084

New issue

Open

opened 2026-03-17 02:33:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:33:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5158
Author: @evanqhuang
Created: 6/17/2025
Status: 🔄 Open

Base: main ← Head: fix/env-vars-race-condition

📝 Commits (1)

6ac29ff fix: update environment variables immediately after pre-request script execution

📊 Changes

1 file changed (+23 additions, -5 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/RequestRunner.ts (+23 -5)

📄 Description

…t execution

This change addresses a race condition where environment variables set in pre-request scripts weren't immediately available to concurrent requests.

https://github.com/hoppscotch/hoppscotch/issues/4788

Changes:

Added updateEnvironmentsFromScript helper to eliminate code duplication
Update environments immediately after pre-request script execution in both runRESTRequest$ and runTestRunnerRequest
Ensures environment changes are persisted before request execution continues

Closes #

What's changed

Notes to reviewers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5158 **Author:** [@evanqhuang](https://github.com/evanqhuang) **Created:** 6/17/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/env-vars-race-condition` --- ### 📝 Commits (1) - [`6ac29ff`](https://github.com/hoppscotch/hoppscotch/commit/6ac29ff547acfd7e244966ca947c5846398a6529) fix: update environment variables immediately after pre-request script execution ### 📊 Changes **1 file changed** (+23 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/RequestRunner.ts` (+23 -5) </details> ### 📄 Description …t execution This change addresses a race condition where environment variables set in pre-request scripts weren't immediately available to concurrent requests. https://github.com/hoppscotch/hoppscotch/issues/4788 Changes: - Added updateEnvironmentsFromScript helper to eliminate code duplication - Update environments immediately after pre-request script execution in both runRESTRequest$ and runTestRunnerRequest - Ensures environment changes are persisted before request execution continues   Closes #   ### What's changed   ### Notes to reviewers  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>