[PR #4836] [MERGED] fix(common): resolve issues around shared workspace invite validation #4956

New issue

Closed

opened 2026-03-17 02:27:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:27:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4836
Author: @jamesgeorge007
Created: 3/5/2025
Status: ✅ Merged
Merged: 3/6/2025
Merged by: @jamesgeorge007

Base: patch ← Head: hotfix/team-invite-validation

📝 Commits (1)

100f376 fix: resolve issues around shared workspace invite validation

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-common/src/pages/join-team.vue (+6 -0)

📄 Description

Closes #4824 HFE-774.

What's changed

This PR aims to resolve issues encountered when a user attempts to join a shared workspace and is greeted with an error screen. This is observed particularly in the cloud offering. This happens when the GQL query executed while a user visits the invite link fails with the message auth/fail since the login state is not confirmed yet. The proposed changes ensure the relevant login state is confirmed before the network call, maintaining backwards compatibility with SH.

Notes to reviewers

N/A

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4836 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `hotfix/team-invite-validation` --- ### 📝 Commits (1) - [`100f376`](https://github.com/hoppscotch/hoppscotch/commit/100f376f383918c42fa8c6920055b0f596d1fb8e) fix: resolve issues around shared workspace invite validation ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/pages/join-team.vue` (+6 -0) </details> ### 📄 Description Closes #4824 HFE-774. ### What's changed This PR aims to resolve issues encountered when a user attempts to join a shared workspace and is greeted with an error screen. This is observed particularly in the cloud offering. This happens when the GQL query executed while a user visits the invite link fails with the message `auth/fail` since the login state is not confirmed yet. The proposed changes ensure the relevant login state is confirmed before the network call, maintaining backwards compatibility with SH. ### Notes to reviewers N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>