[PR #4478] [MERGED] fix: codegen breaking in example tab and minor UI updates #4824

Closed
opened 2026-03-17 02:19:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4478
Author: @nivedin
Created: 10/25/2024
Status: Merged
Merged: 10/28/2024
Merged by: @jamesgeorge007

Base: nextHead: fix/codegen-break-in-example-and-ui


📝 Commits (4)

  • 658c8e0 fix: codegen breaking in example tab
  • 8494f22 chore: minor ui update and type fix
  • 8374d81 chore: update invite modal i18n texts
  • 53ff9ce chore: account for user not found in SHE instance case

📊 Changes

7 files changed (+36 additions, -14 deletions)

View changed files

📝 packages/hoppscotch-common/locales/en.json (+6 -5)
📝 packages/hoppscotch-common/src/components/collections/Request.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/http/Codegen.vue (+12 -2)
📝 packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue (+5 -2)
📝 packages/hoppscotch-common/src/components/lenses/renderers/RawLensRenderer.vue (+5 -2)
📝 packages/hoppscotch-common/src/components/teams/Invite.vue (+6 -2)
📝 packages/hoppscotch-common/src/helpers/backend/mutations/TeamInvitation.ts (+1 -0)

📄 Description

Closes HFE-637 HFE-630

This PR fixes the following

  • Bug with codegen section where it was breaking when the response example tab was active
  • Minor UI polish
  • Update team invite UI and i18n strings for more intuitive text. Also, accounts for the case when a user being invited to a team is not a member of the SHE instance yet.
    image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4478 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 10/25/2024 **Status:** ✅ Merged **Merged:** 10/28/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/codegen-break-in-example-and-ui` --- ### 📝 Commits (4) - [`658c8e0`](https://github.com/hoppscotch/hoppscotch/commit/658c8e06778c8c86e6b66f3164df88ffa9f8f925) fix: codegen breaking in example tab - [`8494f22`](https://github.com/hoppscotch/hoppscotch/commit/8494f22a03fc3f55577c32c0eaa7bf6e984cc0be) chore: minor ui update and type fix - [`8374d81`](https://github.com/hoppscotch/hoppscotch/commit/8374d81ce5f1ec8ac5a0c92bd1382873d8ee8d45) chore: update invite modal i18n texts - [`53ff9ce`](https://github.com/hoppscotch/hoppscotch/commit/53ff9cecaee0233501eaa828439462e751d30cb5) chore: account for user not found in SHE instance case ### 📊 Changes **7 files changed** (+36 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/locales/en.json` (+6 -5) 📝 `packages/hoppscotch-common/src/components/collections/Request.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/http/Codegen.vue` (+12 -2) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue` (+5 -2) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/RawLensRenderer.vue` (+5 -2) 📝 `packages/hoppscotch-common/src/components/teams/Invite.vue` (+6 -2) 📝 `packages/hoppscotch-common/src/helpers/backend/mutations/TeamInvitation.ts` (+1 -0) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes HFE-637 HFE-630 <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> This PR fixes the following - Bug with codegen section where it was breaking when the response example tab was active - Minor UI polish - Update team invite UI and i18n strings for more intuitive text. Also, accounts for the case when a user being invited to a team is not a member of the SHE instance yet. ![image](https://github.com/user-attachments/assets/d30c05a4-42ec-4ef4-9854-f017c0912e8e) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:19:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4824
No description provided.